From: Andrew Morton <akpm@linux-foundation.org>
To: Dave Young <hidave.darkstar@gmail.com>
Cc: Ingo Molnar <mingo@elte.hu>,
linux-kernel@vger.kernel.org,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH] printk boot_delay: use loops_per_msec instead of printk_delay_msec
Date: Mon, 22 Jun 2009 22:55:53 -0700 [thread overview]
Message-ID: <20090622225553.8aa1dfb7.akpm@linux-foundation.org> (raw)
In-Reply-To: <a8e1da0906160202r7124b8a7x29ace04cd910df52@mail.gmail.com>
On Tue, 16 Jun 2009 17:02:24 +0800 Dave Young <hidave.darkstar@gmail.com> wrote:
> Sorry, should post this firstly because the previous printk_delay
> patch depends on this,
> please review, thanks.
> --
>
> Use loops_per_msec instead of printk_delay_msec for boot printk delay.
>
The changelog is poor, because it fails to describe _why_ this change
is being made. I rewrote it to
Rename `printk_delay_msec' to `loops_per_msec', because the patch
"printk: add printk_delay to make messages readable for some
scenarios" wishes to more appropriately use the `printk_delay_msec'
identifier.
>
> --- linux-2.6.orig/kernel/printk.c 2009-06-15 10:53:10.000000000 +0800
> +++ linux-2.6/kernel/printk.c 2009-06-15 13:17:13.000000000 +0800
> @@ -198,12 +198,11 @@ __setup("log_buf_len=", log_buf_len_setu
> #ifdef CONFIG_BOOT_PRINTK_DELAY
>
> static unsigned int boot_delay; /* msecs delay after each printk
> during bootup */
> -static unsigned long long printk_delay_msec; /* per msec, based on
> boot_delay */
Your email client is wordwrapping the patches.
next prev parent reply other threads:[~2009-06-23 5:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-16 9:02 [PATCH] printk boot_delay: use loops_per_msec instead of printk_delay_msec Dave Young
2009-06-23 5:55 ` Andrew Morton [this message]
2009-06-23 12:43 ` Dave Young
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090622225553.8aa1dfb7.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=hidave.darkstar@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox