Re: [PATCH] printk boot_delay: use loops_per_msec instead of printk_delay_msec

[Dave Young <hidave.darkstar@gmail.com>]

On Mon, Jun 22, 2009 at 10:55:53PM -0700, Andrew Morton wrote:
> On Tue, 16 Jun 2009 17:02:24 +0800 Dave Young <hidave.darkstar@gmail.com> wrote:
> 
> > Sorry, should post this firstly because the previous printk_delay
> > patch depends on this,
> > please review, thanks.
> > --
> > 
> > Use loops_per_msec instead of printk_delay_msec for boot printk delay.
> > 
> 
> The changelog is poor, because it fails to describe _why_ this change
> is being made.  I rewrote it to
> 
>   Rename `printk_delay_msec' to `loops_per_msec', because the patch
>   "printk: add printk_delay to make messages readable for some
>   scenarios" wishes to more appropriately use the `printk_delay_msec'
>   identifier.

Thanks for your improval.

> 
> > 
> > --- linux-2.6.orig/kernel/printk.c	2009-06-15 10:53:10.000000000 +0800
> > +++ linux-2.6/kernel/printk.c	2009-06-15 13:17:13.000000000 +0800
> > @@ -198,12 +198,11 @@ __setup("log_buf_len=", log_buf_len_setu
> >  #ifdef CONFIG_BOOT_PRINTK_DELAY
> > 
> >  static unsigned int boot_delay; /* msecs delay after each printk
> > during bootup */
> > -static unsigned long long printk_delay_msec; /* per msec, based on
> > boot_delay */
> 
> Your email client is wordwrapping the patches.


Thanks, I moved from mutt to web gmail + firefox 'view source with' addon, looks like I should think about using mutt again.