From: Dave Young <hidave.darkstar@gmail.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: akpm@linux-foundation.org, mm-commits@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: + printk-add-printk_delay-to-make-messages-readable-for-some-scenarios .patch added to -mm tree
Date: Tue, 23 Jun 2009 20:45:58 +0800 [thread overview]
Message-ID: <20090623124558.GC12135@darkstar> (raw)
In-Reply-To: <20090623071944.GB5747@elte.hu>
On Tue, Jun 23, 2009 at 09:19:44AM +0200, Ingo Molnar wrote:
>
> two minor comments:
Thanks for your comments and andrew's fixes.
>
> > +++ a/kernel/printk.c
> > @@ -640,6 +640,19 @@ static int recursion_bug;
> > static int new_text_line = 1;
> > static char printk_buf[1024];
> >
> > +int printk_delay_msec;
>
> should be __read_mostly.
>
> > +
> > +static inline void printk_delay(void)
> > +{
> > + if (unlikely(printk_delay_msec)) {
> > + int m = printk_delay_msec;
> > + while (m--) {
>
> newline needed after local variable.
>
> Ingo
prev parent reply other threads:[~2009-06-23 12:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200906230552.n5N5q3al012876@imap1.linux-foundation.org>
2009-06-23 7:19 ` + printk-add-printk_delay-to-make-messages-readable-for-some-scenarios .patch added to -mm tree Ingo Molnar
2009-06-23 12:45 ` Dave Young [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090623124558.GC12135@darkstar \
--to=hidave.darkstar@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mm-commits@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox