* Re: + printk-add-printk_delay-to-make-messages-readable-for-some-scenarios .patch added to -mm tree
[not found] <200906230552.n5N5q3al012876@imap1.linux-foundation.org>
@ 2009-06-23 7:19 ` Ingo Molnar
2009-06-23 12:45 ` Dave Young
0 siblings, 1 reply; 2+ messages in thread
From: Ingo Molnar @ 2009-06-23 7:19 UTC (permalink / raw)
To: akpm; +Cc: mm-commits, hidave.darkstar, linux-kernel
two minor comments:
> +++ a/kernel/printk.c
> @@ -640,6 +640,19 @@ static int recursion_bug;
> static int new_text_line = 1;
> static char printk_buf[1024];
>
> +int printk_delay_msec;
should be __read_mostly.
> +
> +static inline void printk_delay(void)
> +{
> + if (unlikely(printk_delay_msec)) {
> + int m = printk_delay_msec;
> + while (m--) {
newline needed after local variable.
Ingo
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: + printk-add-printk_delay-to-make-messages-readable-for-some-scenarios .patch added to -mm tree
2009-06-23 7:19 ` + printk-add-printk_delay-to-make-messages-readable-for-some-scenarios .patch added to -mm tree Ingo Molnar
@ 2009-06-23 12:45 ` Dave Young
0 siblings, 0 replies; 2+ messages in thread
From: Dave Young @ 2009-06-23 12:45 UTC (permalink / raw)
To: Ingo Molnar; +Cc: akpm, mm-commits, linux-kernel
On Tue, Jun 23, 2009 at 09:19:44AM +0200, Ingo Molnar wrote:
>
> two minor comments:
Thanks for your comments and andrew's fixes.
>
> > +++ a/kernel/printk.c
> > @@ -640,6 +640,19 @@ static int recursion_bug;
> > static int new_text_line = 1;
> > static char printk_buf[1024];
> >
> > +int printk_delay_msec;
>
> should be __read_mostly.
>
> > +
> > +static inline void printk_delay(void)
> > +{
> > + if (unlikely(printk_delay_msec)) {
> > + int m = printk_delay_msec;
> > + while (m--) {
>
> newline needed after local variable.
>
> Ingo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-06-23 12:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <200906230552.n5N5q3al012876@imap1.linux-foundation.org>
2009-06-23 7:19 ` + printk-add-printk_delay-to-make-messages-readable-for-some-scenarios .patch added to -mm tree Ingo Molnar
2009-06-23 12:45 ` Dave Young
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox