* [PATCH -tip] perf stat: define CHECK_ATTRS for easy attrs checking
@ 2009-06-29 11:19 Jaswinder Singh Rajput
2009-06-30 10:08 ` Ingo Molnar
0 siblings, 1 reply; 3+ messages in thread
From: Jaswinder Singh Rajput @ 2009-06-29 11:19 UTC (permalink / raw)
To: Ingo Molnar, Thomas Gleixner, Peter Zijlstra, LKML
CHECK_ATTRS is useful :
1. for multiple attrs checking
2. avoid repetition of PERF_TYPE_ and PERF_COUNT_ and save space
3. avoids line breakage
Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@gmail.com>
---
tools/perf/builtin-stat.c | 18 ++++++++----------
1 files changed, 8 insertions(+), 10 deletions(-)
diff --git a/tools/perf/builtin-stat.c b/tools/perf/builtin-stat.c
index 3e5ea4e..6231b39 100644
--- a/tools/perf/builtin-stat.c
+++ b/tools/perf/builtin-stat.c
@@ -96,6 +96,10 @@ static u64 walltime_nsecs_noise;
static u64 runtime_cycles_avg;
static u64 runtime_cycles_noise;
+#define CHECK_ATTRS(t, c, counter) \
+ (attrs[counter].type == PERF_TYPE_##t && \
+ attrs[counter].config == PERF_COUNT_##c)
+
#define ERR_PERF_OPEN \
"Error: counter %d, sys_perf_counter_open() syscall returned with %d (%s)\n"
@@ -191,11 +195,9 @@ static void read_counter(int counter)
/*
* Save the full runtime - to allow normalization during printout:
*/
- if (attrs[counter].type == PERF_TYPE_SOFTWARE &&
- attrs[counter].config == PERF_COUNT_SW_TASK_CLOCK)
+ if (CHECK_ATTRS(SOFTWARE, SW_TASK_CLOCK, counter))
runtime_nsecs[run_idx] = count[0];
- if (attrs[counter].type == PERF_TYPE_HARDWARE &&
- attrs[counter].config == PERF_COUNT_HW_CPU_CYCLES)
+ if (CHECK_ATTRS(HARDWARE, HW_CPU_CYCLES, counter))
runtime_cycles[run_idx] = count[0];
}
@@ -254,9 +256,7 @@ static void nsec_printout(int counter, u64 *count, u64 *noise)
fprintf(stderr, " %14.6f %-24s", msecs, event_name(counter));
- if (attrs[counter].type == PERF_TYPE_SOFTWARE &&
- attrs[counter].config == PERF_COUNT_SW_TASK_CLOCK) {
-
+ if (CHECK_ATTRS(SOFTWARE, SW_TASK_CLOCK, counter)) {
if (walltime_nsecs_avg)
fprintf(stderr, " # %10.3f CPUs ",
(double)count[0] / (double)walltime_nsecs_avg);
@@ -269,9 +269,7 @@ static void abs_printout(int counter, u64 *count, u64 *noise)
fprintf(stderr, " %14Ld %-24s", count[0], event_name(counter));
if (runtime_cycles_avg &&
- attrs[counter].type == PERF_TYPE_HARDWARE &&
- attrs[counter].config == PERF_COUNT_HW_INSTRUCTIONS) {
-
+ CHECK_ATTRS(HARDWARE, HW_INSTRUCTIONS, counter)) {
fprintf(stderr, " # %10.3f IPC ",
(double)count[0] / (double)runtime_cycles_avg);
} else {
--
1.6.0.6
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH -tip] perf stat: define CHECK_ATTRS for easy attrs checking
2009-06-29 11:19 [PATCH -tip] perf stat: define CHECK_ATTRS for easy attrs checking Jaswinder Singh Rajput
@ 2009-06-30 10:08 ` Ingo Molnar
2009-06-30 13:09 ` Jaswinder Singh Rajput
0 siblings, 1 reply; 3+ messages in thread
From: Ingo Molnar @ 2009-06-30 10:08 UTC (permalink / raw)
To: Jaswinder Singh Rajput; +Cc: Thomas Gleixner, Peter Zijlstra, LKML
* Jaswinder Singh Rajput <jaswinder@kernel.org> wrote:
> CHECK_ATTRS is useful :
> 1. for multiple attrs checking
> 2. avoid repetition of PERF_TYPE_ and PERF_COUNT_ and save space
> 3. avoids line breakage
>
> Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@gmail.com>
> ---
> tools/perf/builtin-stat.c | 18 ++++++++----------
> 1 files changed, 8 insertions(+), 10 deletions(-)
>
> diff --git a/tools/perf/builtin-stat.c b/tools/perf/builtin-stat.c
> index 3e5ea4e..6231b39 100644
> --- a/tools/perf/builtin-stat.c
> +++ b/tools/perf/builtin-stat.c
> @@ -96,6 +96,10 @@ static u64 walltime_nsecs_noise;
> static u64 runtime_cycles_avg;
> static u64 runtime_cycles_noise;
>
> +#define CHECK_ATTRS(t, c, counter) \
> + (attrs[counter].type == PERF_TYPE_##t && \
> + attrs[counter].config == PERF_COUNT_##c)
looks good except that the name should be something like
MATCH_EVENT() not CHECK_ATTRS().
Ingo
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH -tip] perf stat: define CHECK_ATTRS for easy attrs checking
2009-06-30 10:08 ` Ingo Molnar
@ 2009-06-30 13:09 ` Jaswinder Singh Rajput
0 siblings, 0 replies; 3+ messages in thread
From: Jaswinder Singh Rajput @ 2009-06-30 13:09 UTC (permalink / raw)
To: Ingo Molnar; +Cc: Thomas Gleixner, Peter Zijlstra, LKML
On Tue, 2009-06-30 at 12:08 +0200, Ingo Molnar wrote:
> * Jaswinder Singh Rajput <jaswinder@kernel.org> wrote:
>
> > CHECK_ATTRS is useful :
> > 1. for multiple attrs checking
> > 2. avoid repetition of PERF_TYPE_ and PERF_COUNT_ and save space
> > 3. avoids line breakage
> >
> > Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@gmail.com>
> > ---
> > tools/perf/builtin-stat.c | 18 ++++++++----------
> > 1 files changed, 8 insertions(+), 10 deletions(-)
> >
> > diff --git a/tools/perf/builtin-stat.c b/tools/perf/builtin-stat.c
> > index 3e5ea4e..6231b39 100644
> > --- a/tools/perf/builtin-stat.c
> > +++ b/tools/perf/builtin-stat.c
> > @@ -96,6 +96,10 @@ static u64 walltime_nsecs_noise;
> > static u64 runtime_cycles_avg;
> > static u64 runtime_cycles_noise;
> >
> > +#define CHECK_ATTRS(t, c, counter) \
> > + (attrs[counter].type == PERF_TYPE_##t && \
> > + attrs[counter].config == PERF_COUNT_##c)
>
> looks good except that the name should be something like
> MATCH_EVENT() not CHECK_ATTRS().
>
[PATCH -tip] perf stat: define MATCH_EVENT for easy attrs checking
MATCH_EVENT is useful :
1. for multiple attrs checking
2. avoid repetition of PERF_TYPE_ and PERF_COUNT_ and save space
3. avoids line breakage
Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@gmail.com>
---
tools/perf/builtin-stat.c | 18 ++++++++----------
1 files changed, 8 insertions(+), 10 deletions(-)
diff --git a/tools/perf/builtin-stat.c b/tools/perf/builtin-stat.c
index 3e5ea4e..00feb8d 100644
--- a/tools/perf/builtin-stat.c
+++ b/tools/perf/builtin-stat.c
@@ -96,6 +96,10 @@ static u64 walltime_nsecs_noise;
static u64 runtime_cycles_avg;
static u64 runtime_cycles_noise;
+#define MATCH_EVENT(t, c, counter) \
+ (attrs[counter].type == PERF_TYPE_##t && \
+ attrs[counter].config == PERF_COUNT_##c)
+
#define ERR_PERF_OPEN \
"Error: counter %d, sys_perf_counter_open() syscall returned with %d (%s)\n"
@@ -191,11 +195,9 @@ static void read_counter(int counter)
/*
* Save the full runtime - to allow normalization during printout:
*/
- if (attrs[counter].type == PERF_TYPE_SOFTWARE &&
- attrs[counter].config == PERF_COUNT_SW_TASK_CLOCK)
+ if (MATCH_EVENT(SOFTWARE, SW_TASK_CLOCK, counter))
runtime_nsecs[run_idx] = count[0];
- if (attrs[counter].type == PERF_TYPE_HARDWARE &&
- attrs[counter].config == PERF_COUNT_HW_CPU_CYCLES)
+ if (MATCH_EVENT(HARDWARE, HW_CPU_CYCLES, counter))
runtime_cycles[run_idx] = count[0];
}
@@ -254,9 +256,7 @@ static void nsec_printout(int counter, u64 *count, u64 *noise)
fprintf(stderr, " %14.6f %-24s", msecs, event_name(counter));
- if (attrs[counter].type == PERF_TYPE_SOFTWARE &&
- attrs[counter].config == PERF_COUNT_SW_TASK_CLOCK) {
-
+ if (MATCH_EVENT(SOFTWARE, SW_TASK_CLOCK, counter)) {
if (walltime_nsecs_avg)
fprintf(stderr, " # %10.3f CPUs ",
(double)count[0] / (double)walltime_nsecs_avg);
@@ -269,9 +269,7 @@ static void abs_printout(int counter, u64 *count, u64 *noise)
fprintf(stderr, " %14Ld %-24s", count[0], event_name(counter));
if (runtime_cycles_avg &&
- attrs[counter].type == PERF_TYPE_HARDWARE &&
- attrs[counter].config == PERF_COUNT_HW_INSTRUCTIONS) {
-
+ MATCH_EVENT(HARDWARE, HW_INSTRUCTIONS, counter)) {
fprintf(stderr, " # %10.3f IPC ",
(double)count[0] / (double)runtime_cycles_avg);
} else {
--
1.6.0.6
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-06-30 13:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-06-29 11:19 [PATCH -tip] perf stat: define CHECK_ATTRS for easy attrs checking Jaswinder Singh Rajput
2009-06-30 10:08 ` Ingo Molnar
2009-06-30 13:09 ` Jaswinder Singh Rajput
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox