[PATCH for-2.6.32] sound dapm: fix checking for external widgets bug

[PATCH for-2.6.32] sound dapm: fix checking for external widgets bug

[Rongrong Cao]

From: Rongrong Cao rrcao@ambarella.com

This patch is based on for-2.6.32
In SOC DAPM layer of SOUND subsystem, when add signal route (in the function snd_soc_dapm_add_route() ), 
the original code has wrong logic when dapm layer check each widget whether an external one.

---------------------------------------------------------------------------------------------------------

--- for-2.6.32/sound/soc/soc-dapm.c.orig        2009-07-08 13:33:41.000000000 +0800
+++ for-2.6.32/sound/soc/soc-dapm.c     2009-07-08 13:34:50.000000000 +0800
@@ -1290,8 +1290,8 @@ static int snd_soc_dapm_add_route(struct
        if (wsink->id == snd_soc_dapm_input) {
                if (wsource->id == snd_soc_dapm_micbias ||
                        wsource->id == snd_soc_dapm_mic ||
-                       wsink->id == snd_soc_dapm_line ||
-                       wsink->id == snd_soc_dapm_output)
+                       wsource->id == snd_soc_dapm_line ||
+                       wsource->id == snd_soc_dapm_output)
                        wsink->ext = 1;
        }
        if (wsource->id == snd_soc_dapm_output) {

---------------------------------------------------------------------------------------------------------

Signed-off-by: Rongrong Cao <rrcao@ambarella.com>


********************
Best regards!
Allen (Rongrong) Cao
Ambarella Shanghai Ltd.
Tel:   (86-21) 50942311
Fax:  (86-21) 50942321

Re: [PATCH for-2.6.32] sound dapm: fix checking for external widgets bug

[Mark Brown]

On Tue, Jul 07, 2009 at 11:11:46PM -0700, Rongrong Cao wrote:
> From: Rongrong Cao rrcao@ambarella.com

> This patch is based on for-2.6.32
> In SOC DAPM layer of SOUND subsystem, when add signal route (in the function snd_soc_dapm_add_route() ), 
> the original code has wrong logic when dapm layer check each widget whether an external one.

This still doesn't apply.  It looks like your MUA is corrupting the
patch - it's MIME encoded everything and replaced all the tabs with
spaces which is causing all the patch application programs I have to get
confused.  Documentation/email-clients.txt has some suggestions on how
to configure various MUAs to send patches cleanly.  Personally I always
use git send-email.  You probably also want to have a look at the
instructions in Documentation/SubmittingPatches with regard to the
formatting of your patch - the main thing being that the Signed-off-by
should go before the patch content.

In any case, I've manually applied the patch so no need to resubmit it.

I also notice that you've CCed trivial@kernel.org.  Please don't do that
except for things that can't possibly cause bugs - a change like this
doesn't really qualify since while the code clearly looks buggy it's
always possible that the code is just obscure.

Re: [PATCH for-2.6.32] sound dapm: fix checking for external widgets bug

[Jiri Kosina]

On Fri, 10 Jul 2009, Mark Brown wrote:

> I also notice that you've CCed trivial@kernel.org.  Please don't do that 
> except for things that can't possibly cause bugs - a change like this 
> doesn't really qualify since while the code clearly looks buggy it's 
> always possible that the code is just obscure.

Absolutely. 

Nevertheless, when the patch doesn't qualify for trivial queue, and I see 
proper maintainers being also involved, I just silently skip the patch, 
otherwise I just add proper maintainers to CC and don't apply it to 
trivial queue.

-- 
Jiri Kosina
SUSE Labs

答复: [PATCH for-2.6.32] sound dapm: fix checking for external widgets bug

[Rongrong Cao]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="utf-8", Size: 2212 bytes --]

Hi, Mark

I'm sorry for sending the unqualified patches two times.
It's my first time to submit patch into kernels, so I'm in lack of the submitting experiences.

I'll read the documents carefully, and I want to submit a codec(CS24L51) driver patch in recently
future. I hope everything will go with a swing at that time.

Thanks!

********************
Best regards!
Allen (Rongrong) Cao
Ambarella Shanghai Ltd.
Tel:   (86-21) 50942311
Fax:  (86-21) 50942321


-----邮件原件-----
发件人: Mark Brown [mailto:broonie@opensource.wolfsonmicro.com] 
发送时间: 2009年7月11日 3:19
收件人: Rongrong Cao
抄送: alsa-devel@alsa-project.org; linux-kernel@vger.kernel.org; trivial@kernel.org
主题: Re: [PATCH for-2.6.32] sound dapm: fix checking for external widgets bug

On Tue, Jul 07, 2009 at 11:11:46PM -0700, Rongrong Cao wrote:
> From: Rongrong Cao rrcao@ambarella.com

> This patch is based on for-2.6.32
> In SOC DAPM layer of SOUND subsystem, when add signal route (in the function snd_soc_dapm_add_route() ), 
> the original code has wrong logic when dapm layer check each widget whether an external one.

This still doesn't apply.  It looks like your MUA is corrupting the
patch - it's MIME encoded everything and replaced all the tabs with
spaces which is causing all the patch application programs I have to get
confused.  Documentation/email-clients.txt has some suggestions on how
to configure various MUAs to send patches cleanly.  Personally I always
use git send-email.  You probably also want to have a look at the
instructions in Documentation/SubmittingPatches with regard to the
formatting of your patch - the main thing being that the Signed-off-by
should go before the patch content.

In any case, I've manually applied the patch so no need to resubmit it.

I also notice that you've CCed trivial@kernel.org.  Please don't do that
except for things that can't possibly cause bugs - a change like this
doesn't really qualify since while the code clearly looks buggy it's
always possible that the code is just obscure.
ÿôèº{.nÇ+‰·Ÿ®‰­†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a­¢f£¢·hšïêÿ‘êçz_è®\x03(­éšŽŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨è­Ú&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥