From: Arnd Bergmann <arnd@arndb.de>
To: Hank Janssen <hjanssen@microsoft.com>
Cc: Nicolas Palix <npalix@diku.dk>, "gregkh@suse.de" <gregkh@suse.de>,
"kernel-janitors@vger.kernel.org"
<kernel-janitors@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Staging: hv: Transform PDEVICE_OBJECT and DEVICE_OBJECT typedefs into their corresponding structs
Date: Tue, 28 Jul 2009 16:30:39 +0200 [thread overview]
Message-ID: <200907281630.39684.arnd@arndb.de> (raw)
In-Reply-To: <12B00476-1E0D-46B1-8939-DD36A0C3D197@microsoft.com>
On Tuesday 28 July 2009, Hank Janssen wrote:
> Excellent suggestion. I will submit a patch to call it hv_vmbus_device
> which makes it even more clear.
Ok. IMHO it's also important to keep the name space consistent, so
if you name it hv_vmbus_device instead of vmbus_device, you should
consequently also rename all other vmbus_* names to hv_vmbus_*
in follow-on patches. If you don't plan to do that, I guess
vmbus_device is fine as well.
Arnd <><
next prev parent reply other threads:[~2009-07-28 14:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-28 8:30 [PATCH] Staging: hv: Transform PDEVICE_OBJECT and DEVICE_OBJECT typedefs into their corresponding structs Nicolas Palix
2009-07-28 13:40 ` Arnd Bergmann
2009-07-28 14:16 ` Hank Janssen
2009-07-28 14:30 ` Arnd Bergmann [this message]
2009-07-28 14:41 ` Greg KH
2009-07-28 15:01 ` Nicolas Palix
2009-07-28 15:07 ` Matthew Wilcox
2009-07-28 15:13 ` Greg KH
2009-07-28 15:18 ` Arnd Bergmann
2009-07-28 15:32 ` Nicolas Palix
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200907281630.39684.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=gregkh@suse.de \
--cc=hjanssen@microsoft.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=npalix@diku.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox