From: Nicolas Palix <npalix@diku.dk>
To: Greg KH <gregkh@suse.de>
Cc: hjanssen@microsoft.com, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: hv: Transform PDEVICE_OBJECT and DEVICE_OBJECT typedefs into their corresponding structs
Date: Tue, 28 Jul 2009 17:01:42 +0200 [thread overview]
Message-ID: <200907281701.43509.npalix@diku.dk> (raw)
In-Reply-To: <20090728144123.GB13883@suse.de>
On Tuesday 28 July 2009 16:41:23 Greg KH wrote:
> On Tue, Jul 28, 2009 at 10:30:44AM +0200, Nicolas Palix wrote:
> >
> > Remove typedef DEVICE_OBJECT and use a struct with the same name
> > instead. The new struct name uses lower case (struct device_object).
>
> This should be called "struct hv_device" instead, care to respin the
> patch like that to keep us from having to change it again? :)
>
> thanks,
>
> greg k-h
>
Ok. So, I guess the pattern for the other typedef is to strip the _OBJECT
suffix when present, and always add the prefix hv_, right ?
--
Nicolas Palix
next prev parent reply other threads:[~2009-07-28 15:01 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-28 8:30 [PATCH] Staging: hv: Transform PDEVICE_OBJECT and DEVICE_OBJECT typedefs into their corresponding structs Nicolas Palix
2009-07-28 13:40 ` Arnd Bergmann
2009-07-28 14:16 ` Hank Janssen
2009-07-28 14:30 ` Arnd Bergmann
2009-07-28 14:41 ` Greg KH
2009-07-28 15:01 ` Nicolas Palix [this message]
2009-07-28 15:07 ` Matthew Wilcox
2009-07-28 15:13 ` Greg KH
2009-07-28 15:18 ` Arnd Bergmann
2009-07-28 15:32 ` Nicolas Palix
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200907281701.43509.npalix@diku.dk \
--to=npalix@diku.dk \
--cc=gregkh@suse.de \
--cc=hjanssen@microsoft.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox