From: Andi Kleen <andi@firstfloor.org>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: Andi Kleen <andi@firstfloor.org>, Ingo Molnar <mingo@elte.hu>,
torvalds@linux-foundation.org, fengguang.wu@intel.com,
linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
Thomas Gleixner <tglx@linutronix.de>,
Peter Zijlstra <a.p.zijlstra@chello.nl>
Subject: Re: [origin tree build failure] Re: [PULL] Please pull hwpoison code for 2.6.32
Date: Sat, 26 Sep 2009 19:28:02 +0200 [thread overview]
Message-ID: <20090926172802.GS30185@one.firstfloor.org> (raw)
In-Reply-To: <20090926162046.GQ30185@one.firstfloor.org>
On Sat, Sep 26, 2009 at 10:20:05AM -0700, H. Peter Anvin wrote:
> It doesn't help adjusting NODES_SHIFT - we're already operating in the stressed condition for which NODES_WIDTH == 0 (external node number.)
>
> As such, NUMA vs !NUMA is a red herring - it's really about SPARSEMEM.
>
> (Disclaimer: I have no access to the code at the moment and I only have my cell phone email, but I had to deal with this for another issue recently enough.)
You're right. In theory we could just set the sparsemem block really
large on NUMAQ because it doesn't support memory hotadd anyways, so needing
less bits. But Linus' simple patch is also a solution.
Of course the issue might come up again when someone else needs another
page flags bit.
-Andi
--
ak@linux.intel.com -- Speaking for myself only.
next prev parent reply other threads:[~2009-09-26 17:28 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-16 12:51 [PULL] Please pull hwpoison code for 2.6.32 Andi Kleen
2009-09-26 14:13 ` [origin tree build failure] " Ingo Molnar
2009-09-26 15:17 ` Andi Kleen
2009-09-26 16:20 ` Andi Kleen
2009-09-26 17:28 ` Andi Kleen [this message]
2009-09-26 18:20 ` Andi Kleen
2009-09-26 16:35 ` Linus Torvalds
2009-09-26 17:35 ` [PATCH] x86: Fix hwpoison code related build failure on 32-bit NUMAQ Ingo Molnar
2009-09-26 17:43 ` Linus Torvalds
2009-09-26 18:10 ` Ingo Molnar
2009-09-26 18:12 ` Ingo Molnar
2009-09-26 18:11 ` [origin tree build failure] Re: [PULL] Please pull hwpoison code for 2.6.32 Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090926172802.GS30185@one.firstfloor.org \
--to=andi@firstfloor.org \
--cc=a.p.zijlstra@chello.nl \
--cc=akpm@linux-foundation.org \
--cc=fengguang.wu@intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox