linux-next: acpi tree build failure

linux-next: acpi tree build failure

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 798 bytes --]

Hi Len,

Today's linux-next build (x86_64 allmodconfig) failed like this:

drivers/i2c/busses/i2c-scmi.c: In function 'acpi_smbus_cmi_add':
drivers/i2c/busses/i2c-scmi.c:374: error: implicit declaration of function 'acpi_device_uid'
drivers/i2c/busses/i2c-scmi.c:374: warning: format '%s' expects type 'char *', but argument 5 has type 'int'

Caused by commit 6622d8cee73a26bce958484065c8f0e704911a62 ("ACPI: remove
acpi_device_uid() and related stuff") interacting with commit
dc9854212e0d7318d7133697906d98b78f3088b6 ("i2c: Add driver for SMBus
Control Method Interface") recently added to Linus' tree.

I have used the version of the acpi tree from next-20090925 for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]

Re: linux-next: acpi tree build failure

[Bjorn Helgaas]

On Sat, 2009-09-26 at 12:15 +1000, Stephen Rothwell wrote:
> Hi Len,
> 
> Today's linux-next build (x86_64 allmodconfig) failed like this:
> 
> drivers/i2c/busses/i2c-scmi.c: In function 'acpi_smbus_cmi_add':
> drivers/i2c/busses/i2c-scmi.c:374: error: implicit declaration of function 'acpi_device_uid'
> drivers/i2c/busses/i2c-scmi.c:374: warning: format '%s' expects type 'char *', but argument 5 has type 'int'
> 
> Caused by commit 6622d8cee73a26bce958484065c8f0e704911a62 ("ACPI: remove
> acpi_device_uid() and related stuff") interacting with commit
> dc9854212e0d7318d7133697906d98b78f3088b6 ("i2c: Add driver for SMBus
> Control Method Interface") recently added to Linus' tree.
> 
> I have used the version of the acpi tree from next-20090925 for today.

I think we should use the following patch to remove the usage of
acpi_device_uid().  Crane, do you agree, or is there some special
reason you need it here?



i2c-scmi: don't use acpi_device_uid()
    
We recently removed the acpi_device_uid() interface because nobody
used it.  I don't think it's essential here either.
    
Signed-off-by: Bjorn Helgaas <bjorn.helgaas@hp.com>

diff --git a/drivers/i2c/busses/i2c-scmi.c b/drivers/i2c/busses/i2c-scmi.c
index 276a046..b4a55d4 100644
--- a/drivers/i2c/busses/i2c-scmi.c
+++ b/drivers/i2c/busses/i2c-scmi.c
@@ -369,9 +369,8 @@ static int acpi_smbus_cmi_add(struct acpi_device *device)
 		goto err;
 
 	snprintf(smbus_cmi->adapter.name, sizeof(smbus_cmi->adapter.name),
-		"SMBus CMI adapter %s (%s)",
-		acpi_device_name(device),
-		acpi_device_uid(device));
+		"SMBus CMI adapter %s",
+		acpi_device_name(device));
 	smbus_cmi->adapter.owner = THIS_MODULE;
 	smbus_cmi->adapter.algo = &acpi_smbus_cmi_algorithm;
 	smbus_cmi->adapter.algo_data = smbus_cmi;

Re: linux-next: acpi tree build failure

[Crane Cai]

Hi Bjorn,

On Fri, Sep 25, 2009 at 09:11:43PM -0600, Bjorn Helgaas wrote:
> On Sat, 2009-09-26 at 12:15 +1000, Stephen Rothwell wrote:
> > Hi Len,
> > 
> > Today's linux-next build (x86_64 allmodconfig) failed like this:
> > 
> > drivers/i2c/busses/i2c-scmi.c: In function 'acpi_smbus_cmi_add':
> > drivers/i2c/busses/i2c-scmi.c:374: error: implicit declaration of function 'acpi_device_uid'
> > drivers/i2c/busses/i2c-scmi.c:374: warning: format '%s' expects type 'char *', but argument 5 has type 'int'
> > 
> > Caused by commit 6622d8cee73a26bce958484065c8f0e704911a62 ("ACPI: remove
> > acpi_device_uid() and related stuff") interacting with commit
> > dc9854212e0d7318d7133697906d98b78f3088b6 ("i2c: Add driver for SMBus
> > Control Method Interface") recently added to Linus' tree.
> > 
> > I have used the version of the acpi tree from next-20090925 for today.
> 
> I think we should use the following patch to remove the usage of
> acpi_device_uid().  Crane, do you agree, or is there some special
> reason you need it here?
I agree.
> 
> 
> 

-- 
Best Regards,
- Crane

Re: linux-next: acpi tree build failure

[Len Brown]

> > > drivers/i2c/busses/i2c-scmi.c: In function 'acpi_smbus_cmi_add':
> > > drivers/i2c/busses/i2c-scmi.c:374: error: implicit declaration of function 'acpi_device_uid'
> > > drivers/i2c/busses/i2c-scmi.c:374: warning: format '%s' expects type 'char *', but argument 5 has type 'int'
> > > 
> > > Caused by commit 6622d8cee73a26bce958484065c8f0e704911a62 ("ACPI: remove
> > > acpi_device_uid() and related stuff") interacting with commit
> > > dc9854212e0d7318d7133697906d98b78f3088b6 ("i2c: Add driver for SMBus
> > > Control Method Interface") recently added to Linus' tree.
> > > 
> > > I have used the version of the acpi tree from next-20090925 for today.
> > 
> > I think we should use the following patch to remove the usage of
> > acpi_device_uid().  Crane, do you agree, or is there some special
> > reason you need it here?

> I agree.

Thanks Crane, upstream now includes Bjorn's patch.

-Len Brown, Intel Open Source Technology Center

linux-next: acpi tree build failure

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 448 bytes --]

Hi Len,

Today's linux-next build (x86_64 allmodconfig) failed like this:

ERROR: "pnpacpi_protocol" [drivers/char/ipmi/ipmi_si.ko] undefined!

Caused by commit e80b594fd69039387339e75b4f75c58da74676ae ("PNP: add
interface to retrieve ACPI device from a PNPACPI device").

I have used the acpi tree form next-20091211 for today.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]

Re: linux-next: acpi tree build failure

[Bjorn Helgaas]

On Mon, 2009-12-14 at 12:20 +1100, Stephen Rothwell wrote:
> Today's linux-next build (x86_64 allmodconfig) failed like this:
> 
> ERROR: "pnpacpi_protocol" [drivers/char/ipmi/ipmi_si.ko] undefined!
> 
> Caused by commit e80b594fd69039387339e75b4f75c58da74676ae ("PNP: add
> interface to retrieve ACPI device from a PNPACPI device").

Here's the fix:

commit 28b07e816ecc25567c8ff25e5a0c52f57e55b91f
Author: Bjorn Helgaas <bjorn.helgaas@hp.com>
Date:   Mon Dec 14 21:41:17 2009 -0700

    PNP: export pnpacpi_protocol (for pnp_acpi_device() test)
    
    In e80b594f, I added an exported interface, pnp_acpi_device(), but
    I neglected to export the underlying pnpacpi_protocol symbol.
    
    Signed-off-by: Bjorn Helgaas <bjorn.helgaas@hp.com>

diff --git a/drivers/pnp/pnpacpi/core.c b/drivers/pnp/pnpacpi/core.c
index 8dd0f37..5314bf6 100644
--- a/drivers/pnp/pnpacpi/core.c
+++ b/drivers/pnp/pnpacpi/core.c
@@ -154,6 +154,7 @@ struct pnp_protocol pnpacpi_protocol = {
 	.resume = pnpacpi_resume,
 #endif
 };
+EXPORT_SYMBOL(pnpacpi_protocol);
 
 static int __init pnpacpi_add_device(struct acpi_device *device)
 {

Re: linux-next: acpi tree build failure

[Len Brown]

i merged bjorn's fix into the original offending patch in acpi-test

thanks,
Len Brown, Intel Open Source Technology Center

Re: linux-next: acpi tree build failure

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 289 bytes --]

Hi Len, Bjorn,

On Tue, 15 Dec 2009 17:37:21 -0500 (EST) Len Brown <lenb@kernel.org> wrote:
>
> i merged bjorn's fix into the original offending patch in acpi-test

Thanks.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]

Re: linux-next: acpi tree build failure

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 337 bytes --]

Hi Len,

On Tue, 15 Dec 2009 17:37:21 -0500 (EST) Len Brown <lenb@kernel.org> wrote:
>
> i merged bjorn's fix into the original offending patch in acpi-test

That didn't seem to be in what I fetched for linux-next today.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]

linux-next: acpi tree build failure

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 489 bytes --]

Hi Len,

Today's linux-next build (x86_64 allmodconfig) failed like this:

drivers/acpi/als.c: In function 'acpi_als_get_mappings':
drivers/acpi/als.c:173: error: expected ')' before 'PREFIX'
drivers/acpi/als.c: In function 'acpi_als_add':
drivers/acpi/als.c:347: error: expected ')' before 'PREFIX'

I have used the version of the acpi tree from next-20090831 for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

Re: linux-next: acpi tree build failure

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 617 bytes --]

Hi Len,

On Tue, 1 Sep 2009 12:57:48 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Today's linux-next build (x86_64 allmodconfig) failed like this:
> 
> drivers/acpi/als.c: In function 'acpi_als_get_mappings':
> drivers/acpi/als.c:173: error: expected ')' before 'PREFIX'
> drivers/acpi/als.c: In function 'acpi_als_add':
> drivers/acpi/als.c:347: error: expected ')' before 'PREFIX'
> 
> I have used the version of the acpi tree from next-20090831 for today.

This is still there ...
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

Re: linux-next: acpi tree build failure

[Zhang Rui]

len,

please revert the two ALS patches.

thanks,
rui

On Mon, 2009-09-07 at 21:46 +0800, Stephen Rothwell wrote:
> Hi Len,
> 
> On Tue, 1 Sep 2009 12:57:48 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >
> > Today's linux-next build (x86_64 allmodconfig) failed like this:
> > 
> > drivers/acpi/als.c: In function 'acpi_als_get_mappings':
> > drivers/acpi/als.c:173: error: expected ')' before 'PREFIX'
> > drivers/acpi/als.c: In function 'acpi_als_add':
> > drivers/acpi/als.c:347: error: expected ')' before 'PREFIX'
> > 
> > I have used the version of the acpi tree from next-20090831 for today.
> 
> This is still there ...

Re: linux-next: acpi tree build failure

[Len Brown]

> please revert the two ALS patches.

done.

Sorry about the merge-conflict and build error, Stephen.
You can update to the latest acpi-test tree now.

thanks,
-Len Brown, Intel Open Source Technology Center

Re: linux-next: acpi tree build failure

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 406 bytes --]

Hi Len,

On Wed, 09 Sep 2009 00:02:03 -0400 (EDT) Len Brown <lenb@kernel.org> wrote:
>
> > please revert the two ALS patches.
> 
> done.
> 
> Sorry about the merge-conflict and build error, Stephen.
> You can update to the latest acpi-test tree now.

Thanks, I will pick it up tomorrow.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

linux-next: acpi tree build failure

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 844 bytes --]

Hi Len,

Today's linux-next build (powerpc ppc64_defconfig) failed like this:

  GEN     /scratch/sfr/powerpc_ppc64_defconfig/Makefile
drivers/platform/x86/Kconfig:353:error: found recursive dependency: EEEPC_LAPTOP -> HOTPLUG_PCI -> EEEPC_LAPTOP

Caused by commit 6af05c22969dce2776375953131b56e9f4282848 ("eeepc-laptop:
Register as a pci-hotplug device") interacting with commit
44b3615b8cb3b016a49eb7ef4236e77a77793cec ("eeepc-laptop: Fix build
failure with HOTPLUG_PCI && !SYSFS") from Linus' tree.  Commit 6af05c2
from the acpi tree is the same as commit
2b121bc262fa03c94e653b2d44356c2f86c1bcdc in Linus' tree that 44b3615b is
fixing, so I have reverted the drivers/platform/x86/Kconfig part of
6af05c2 for today.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

Re: linux-next: acpi tree build failure

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 987 bytes --]

Hi Len,

On Tue, 30 Jun 2009 13:16:45 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Today's linux-next build (powerpc ppc64_defconfig) failed like this:
> 
>   GEN     /scratch/sfr/powerpc_ppc64_defconfig/Makefile
> drivers/platform/x86/Kconfig:353:error: found recursive dependency: EEEPC_LAPTOP -> HOTPLUG_PCI -> EEEPC_LAPTOP
> 
> Caused by commit 6af05c22969dce2776375953131b56e9f4282848 ("eeepc-laptop:
> Register as a pci-hotplug device") interacting with commit
> 44b3615b8cb3b016a49eb7ef4236e77a77793cec ("eeepc-laptop: Fix build
> failure with HOTPLUG_PCI && !SYSFS") from Linus' tree.  Commit 6af05c2
> from the acpi tree is the same as commit
> 2b121bc262fa03c94e653b2d44356c2f86c1bcdc in Linus' tree that 44b3615b is
> fixing, so I have reverted the drivers/platform/x86/Kconfig part of
> 6af05c2 for today.

This is still happening ...

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

Re: linux-next: acpi tree build failure

[Len Brown]

On Tue, 30 Jun 2009, Stephen Rothwell wrote:

> Hi Len,
> 
> Today's linux-next build (powerpc ppc64_defconfig) failed like this:
> 
>   GEN     /scratch/sfr/powerpc_ppc64_defconfig/Makefile
> drivers/platform/x86/Kconfig:353:error: found recursive dependency: EEEPC_LAPTOP -> HOTPLUG_PCI -> EEEPC_LAPTOP
> 
> Caused by commit 6af05c22969dce2776375953131b56e9f4282848 ("eeepc-laptop:
> Register as a pci-hotplug device") interacting with commit
> 44b3615b8cb3b016a49eb7ef4236e77a77793cec ("eeepc-laptop: Fix build
> failure with HOTPLUG_PCI && !SYSFS") from Linus' tree.  Commit 6af05c2
> from the acpi tree is the same as commit
> 2b121bc262fa03c94e653b2d44356c2f86c1bcdc in Linus' tree that 44b3615b is
> fixing, so I have reverted the drivers/platform/x86/Kconfig part of
> 6af05c2 for today.

Sorry I broke your build, Stephen.

This was an obsolete patch in the acpi-test tree.
it should be better now.   Thanks for working around it.

Len Brown, Intel Open Source Technology Center

Re: linux-next: acpi tree build failure

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 350 bytes --]

Hi Len,

On Mon, 06 Jul 2009 23:17:29 -0400 (EDT) Len Brown <lenb@kernel.org> wrote:
>
> This was an obsolete patch in the acpi-test tree.
> it should be better now.   Thanks for working around it.

Thanks, I'll pick it up tomorrow.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]