From: Frederic Weisbecker <fweisbec@gmail.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: Peter Zijlstra <peterz@infradead.org>,
Arnaldo Carvalho de Melo <acme@redhat.com>,
Paul Mackerras <paulus@samba.org>, Mike Galbraith <efault@gmx.de>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [RFC][PATCH] perf tools: Merge trace.info content into perf.data
Date: Wed, 7 Oct 2009 10:18:34 +0200 [thread overview]
Message-ID: <20091007081832.GB5043@nowhere> (raw)
In-Reply-To: <20091007064355.GA3283@elte.hu>
On Wed, Oct 07, 2009 at 08:43:55AM +0200, Ingo Molnar wrote:
> Meanwhile i've applied your two patches - they are clear steps forward.
> We'll need the -stable fix so that the new perf.data can be read. (and
> even that only affects -R afaics - so normal perf record / perf report
> is compatible.)
That affects every new perf.data
We have a new trace_info offset/size pair even if we haven't
any trace.info, these will just be zero in that case.
This new pair has grown the header, making it uncompatible.
But the stable patch should solve this.
> Btw., we also need a patch for new perf to read older perf.data files
> [non-trace.info ones], as those are not working either:
>
> $ perf report
> Fatal: incompatible file format
>
> ( We dont want to push it - i.e. i dont think we need to support old
> perf.data + trace.info combos. )
>
> Ingo
Ok.
next prev parent reply other threads:[~2009-10-07 8:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-06 21:36 [RFC][PATCH] perf tools: Merge trace.info content into perf.data Frederic Weisbecker
2009-10-07 6:22 ` Ingo Molnar
2009-10-07 6:43 ` Ingo Molnar
2009-10-07 8:18 ` Frederic Weisbecker [this message]
2009-10-07 8:11 ` Frederic Weisbecker
2009-10-07 6:47 ` Peter Zijlstra
2009-10-07 8:20 ` Frederic Weisbecker
2009-10-07 7:31 ` [tip:perf/core] " tip-bot for Frederic Weisbecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091007081832.GB5043@nowhere \
--to=fweisbec@gmail.com \
--cc=acme@redhat.com \
--cc=efault@gmx.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=paulus@samba.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox