From: Frederic Weisbecker <fweisbec@gmail.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Ingo Molnar <mingo@elte.hu>,
Arnaldo Carvalho de Melo <acme@redhat.com>,
Paul Mackerras <paulus@samba.org>, Mike Galbraith <efault@gmx.de>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [RFC][PATCH] perf tools: Merge trace.info content into perf.data
Date: Wed, 7 Oct 2009 10:20:22 +0200 [thread overview]
Message-ID: <20091007082020.GC5043@nowhere> (raw)
In-Reply-To: <1254898050.26976.146.camel@twins>
On Wed, Oct 07, 2009 at 08:47:30AM +0200, Peter Zijlstra wrote:
> On Tue, 2009-10-06 at 23:36 +0200, Frederic Weisbecker wrote:
> > Hi,
> >
> > Here is an attempt to remove the trace.info file.
> > It works well for me, the reason for it to be an RFC
> > is that I have doubts about the backward compatibility.
> >
> > A file created by perf after his patch is unsupported
> > by previous version because the size of the headers have
> > increased.
> >
> > That said, it's two new fields that have been added in
> > the end of the headers, and those could be ignored by
> > previous versions if they just handled the dynamic header
> > size and then ignore the unknow part. The offsets guarantee
> > the compatibility.
> > But previous versions handle the header size using its
> > static size, not dynamic, then it's not backward compatible.
> >
> > Anyway, I'm not sure exactly how to handle that.
>
> If we're still able to read 'regular' old perf.data files after this.
> That is, allow to read short headers and assume the tail is 0 we'll be
> good. (this will break trace files that rely on the now removed
> trace.info, but that's unavoidable I guess).
>
> So backwards compatible, but no fwd compat for the old perf.
Hmm, but forward is possible. It will just ignore the trace.info
part.
next prev parent reply other threads:[~2009-10-07 8:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-06 21:36 [RFC][PATCH] perf tools: Merge trace.info content into perf.data Frederic Weisbecker
2009-10-07 6:22 ` Ingo Molnar
2009-10-07 6:43 ` Ingo Molnar
2009-10-07 8:18 ` Frederic Weisbecker
2009-10-07 8:11 ` Frederic Weisbecker
2009-10-07 6:47 ` Peter Zijlstra
2009-10-07 8:20 ` Frederic Weisbecker [this message]
2009-10-07 7:31 ` [tip:perf/core] " tip-bot for Frederic Weisbecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091007082020.GC5043@nowhere \
--to=fweisbec@gmail.com \
--cc=acme@redhat.com \
--cc=efault@gmx.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=paulus@samba.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox