staging: where to put system-wide includes

staging: where to put system-wide includes

[Pavel Machek]

Hi!

In staging, I need some includes that will become "system-wide" at the
end.

Is it acceptable to create drivers/staging/include/linux (and
friends), and then use -I magic to include those headers?
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Re: staging: where to put system-wide includes

[Greg KH]

On Thu, Oct 08, 2009 at 01:28:18PM +0200, Pavel Machek wrote:
> Hi!
> 
> In staging, I need some includes that will become "system-wide" at the
> end.
> 
> Is it acceptable to create drivers/staging/include/linux (and
> friends), and then use -I magic to include those headers?

No, keep them in the subdir for the drivers you are adding please and
reference them by the location directly, no -I magic.

thanks,

greg k-h

Re: staging: where to put system-wide includes

[Christoph Hellwig]

On Thu, Oct 08, 2009 at 01:28:18PM +0200, Pavel Machek wrote:
> Hi!
> 
> In staging, I need some includes that will become "system-wide" at the
> end.
> 
> Is it acceptable to create drivers/staging/include/linux (and
> friends), and then use -I magic to include those headers?

If you need system-wide inclusions it's pretty good sign that what
you add is not a simple driver and thus should not just go into the
staging tree.  Given that you're a long-timer kernel hackers what's the
problem with getting your code fully up to kernel standards anyway?

Re: staging: where to put system-wide includes

[Pavel Machek]

On Thu 2009-10-08 14:40:27, Christoph Hellwig wrote:
> On Thu, Oct 08, 2009 at 01:28:18PM +0200, Pavel Machek wrote:
> > Hi!
> > 
> > In staging, I need some includes that will become "system-wide" at the
> > end.
> > 
> > Is it acceptable to create drivers/staging/include/linux (and
> > friends), and then use -I magic to include those headers?
> 
> If you need system-wide inclusions it's pretty good sign that what
> you add is not a simple driver and thus should not just go into the
> staging tree.  Given that you're a long-timer kernel hackers what's the
> problem with getting your code fully up to kernel standards anyway?

Well, it is not exactly my code -- I'm trying to merge HTC Dream
support. Problem with "simply cleaning it up" is that its 122Kloc.

									Pavel

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Re: staging: where to put system-wide includes

[Pavel Machek]

On Thu 2009-10-08 08:00:10, Greg KH wrote:
> On Thu, Oct 08, 2009 at 01:28:18PM +0200, Pavel Machek wrote:
> > Hi!
> > 
> > In staging, I need some includes that will become "system-wide" at the
> > end.
> > 
> > Is it acceptable to create drivers/staging/include/linux (and
> > friends), and then use -I magic to include those headers?
> 
> No, keep them in the subdir for the drivers you are adding please and
> reference them by the location directly, no -I magic.

That will make moving drivers to final place "interesting", but I'll
do as you wish.
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html