From: Ingo Molnar <mingo@elte.hu>
To: Jeff Garzik <jeff@garzik.org>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>,
Thomas Gleixner <tglx@linutronix.de>,
LKML <linux-kernel@vger.kernel.org>,
Arnd Bergmann <arnd@arndb.de>,
Peter Zijlstra <peterz@infradead.org>,
Frederic Weisbecker <fweisbec@gmail.com>
Subject: Re: [RFC] Remove or convert empty ioctls ?
Date: Thu, 15 Oct 2009 17:50:23 +0200 [thread overview]
Message-ID: <20091015155023.GB11408@elte.hu> (raw)
In-Reply-To: <4AD74151.7020306@garzik.org>
* Jeff Garzik <jeff@garzik.org> wrote:
> On 10/15/2009 11:31 AM, Alan Cox wrote:
>> EINVAL means you used an ioctl that is correct for the driver but that
>> for some reason the driver didn't like it.
>
> Precisely.
>
> The driver author proactively chose to implement the ioctl and return
> a value other than ENOTTY.
>
> It is invalid to assume that all such cases are a direct result of
> author mistakes or ignorance.
If 10% of the cases the error return was for a reason it's still worth
doing this. If it matters we'll hear about it.
Something that looks like crap should not get extra protection to stay
in the kernel just because it 'might' be non-crap. If it's not clearly
documented in the source to be -EINVAL for a good reason (and frankly i
cannot think of any) then i'd suggest to do what Alan has been doing for
years: just change it and see if it causes any problems.
It's not like it's hard to revert such a change. (and we'll also add a
comment explaining the reason for the -EINVAL in that case.)
Ingo
prev parent reply other threads:[~2009-10-15 15:51 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-15 9:20 [RFC] Remove or convert empty ioctls ? Thomas Gleixner
2009-10-15 12:12 ` Jeff Garzik
2009-10-15 15:01 ` Alan Cox
2009-10-15 15:22 ` Jeff Garzik
2009-10-15 15:31 ` Alan Cox
2009-10-15 15:35 ` Jeff Garzik
2009-10-15 15:49 ` Alan Cox
2009-10-15 16:03 ` Jeff Garzik
2009-10-15 16:23 ` Thomas Gleixner
2009-10-15 16:28 ` Thomas Gleixner
2009-10-15 15:50 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091015155023.GB11408@elte.hu \
--to=mingo@elte.hu \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=arnd@arndb.de \
--cc=fweisbec@gmail.com \
--cc=jeff@garzik.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox