* [PATCH] pcmcia: fix controller printk format warnings
@ 2009-10-12 1:50 Randy Dunlap
2009-10-12 9:34 ` Wolfram Sang
2009-10-19 9:40 ` Wolfram Sang
0 siblings, 2 replies; 3+ messages in thread
From: Randy Dunlap @ 2009-10-12 1:50 UTC (permalink / raw)
To: LKML, torvalds; +Cc: akpm, gregkh, linux-pcmcia
From: Randy Dunlap <randy.dunlap@oracle.com>
Fix new pcmcia printk format warnings:
[This has now moved from linux-next to mainline.
Originally sent 2009-SEP-17.]
drivers/pcmcia/i82365.c:1055: warning: format '%#x' expects type 'unsigned int', but argument 6 has type 'phys_addr_t'
drivers/pcmcia/i82365.c:1055: warning: format '%#x' expects type 'unsigned int', but argument 7 has type 'phys_addr_t'
drivers/pcmcia/tcic.c:734: warning: format '%#x' expects type 'unsigned int', but argument 6 has type 'phys_addr_t'
drivers/pcmcia/tcic.c:734: warning: format '%#x' expects type 'unsigned int', but argument 7 has type 'phys_addr_t'
Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
---
drivers/pcmcia/i82365.c | 4 ++--
drivers/pcmcia/tcic.c | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
--- linux-next-20090917.orig/drivers/pcmcia/tcic.c
+++ linux-next-20090917/drivers/pcmcia/tcic.c
@@ -732,8 +732,8 @@ static int tcic_set_io_map(struct pcmcia
u_short base, len, ioctl;
debug(1, "SetIOMap(%d, %d, %#2.2x, %d ns, "
- "%#x-%#x)\n", psock, io->map, io->flags,
- io->speed, io->start, io->stop);
+ "%#llx-%#llx)\n", psock, io->map, io->flags, io->speed,
+ (unsigned long long)io->start, (unsigned long long)io->stop);
if ((io->map > 1) || (io->start > 0xffff) || (io->stop > 0xffff) ||
(io->stop < io->start)) return -EINVAL;
tcic_setw(TCIC_ADDR+2, TCIC_ADR2_INDREG | (psock << TCIC_SS_SHFT));
--- linux-next-20090917.orig/drivers/pcmcia/i82365.c
+++ linux-next-20090917/drivers/pcmcia/i82365.c
@@ -1053,8 +1053,8 @@ static int i365_set_io_map(u_short sock,
u_char map, ioctl;
debug(1, "SetIOMap(%d, %d, %#2.2x, %d ns, "
- "%#x-%#x)\n", sock, io->map, io->flags,
- io->speed, io->start, io->stop);
+ "%#llx-%#llx)\n", sock, io->map, io->flags, io->speed,
+ (unsigned long long)io->start, (unsigned long long)io->stop);
map = io->map;
if ((map > 1) || (io->start > 0xffff) || (io->stop > 0xffff) ||
(io->stop < io->start)) return -EINVAL;
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] pcmcia: fix controller printk format warnings
2009-10-12 1:50 [PATCH] pcmcia: fix controller printk format warnings Randy Dunlap
@ 2009-10-12 9:34 ` Wolfram Sang
2009-10-19 9:40 ` Wolfram Sang
1 sibling, 0 replies; 3+ messages in thread
From: Wolfram Sang @ 2009-10-12 9:34 UTC (permalink / raw)
To: Randy Dunlap; +Cc: LKML, torvalds, akpm, gregkh, linux-pcmcia
[-- Attachment #1: Type: text/plain, Size: 656 bytes --]
On Sun, Oct 11, 2009 at 06:50:09PM -0700, Randy Dunlap wrote:
> From: Randy Dunlap <randy.dunlap@oracle.com>
>
> Fix new pcmcia printk format warnings:
> [This has now moved from linux-next to mainline.
> Originally sent 2009-SEP-17.]
My plan was to pick it for pcmcia-l2 and ask Greg to pull it next week (after
ELC-E) together with my follow-up patch. If this is not fast enough, just let
me know someone else picked it and I'll handle my patch seperately.
Regards,
Wolfram
--
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 197 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] pcmcia: fix controller printk format warnings
2009-10-12 1:50 [PATCH] pcmcia: fix controller printk format warnings Randy Dunlap
2009-10-12 9:34 ` Wolfram Sang
@ 2009-10-19 9:40 ` Wolfram Sang
1 sibling, 0 replies; 3+ messages in thread
From: Wolfram Sang @ 2009-10-19 9:40 UTC (permalink / raw)
To: Randy Dunlap; +Cc: LKML, torvalds, akpm, gregkh, linux-pcmcia
[-- Attachment #1: Type: text/plain, Size: 998 bytes --]
On Sun, Oct 11, 2009 at 06:50:09PM -0700, Randy Dunlap wrote:
> From: Randy Dunlap <randy.dunlap@oracle.com>
>
> Fix new pcmcia printk format warnings:
> [This has now moved from linux-next to mainline.
> Originally sent 2009-SEP-17.]
>
> drivers/pcmcia/i82365.c:1055: warning: format '%#x' expects type 'unsigned int', but argument 6 has type 'phys_addr_t'
> drivers/pcmcia/i82365.c:1055: warning: format '%#x' expects type 'unsigned int', but argument 7 has type 'phys_addr_t'
> drivers/pcmcia/tcic.c:734: warning: format '%#x' expects type 'unsigned int', but argument 6 has type 'phys_addr_t'
> drivers/pcmcia/tcic.c:734: warning: format '%#x' expects type 'unsigned int', but argument 7 has type 'phys_addr_t'
>
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
Acked-by: Wolfram Sang <w.sang@pengutronix.de>
--
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 197 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-10-19 9:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-10-12 1:50 [PATCH] pcmcia: fix controller printk format warnings Randy Dunlap
2009-10-12 9:34 ` Wolfram Sang
2009-10-19 9:40 ` Wolfram Sang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox