From: Frederic Weisbecker <fweisbec@gmail.com>
To: "Leonidas ." <leonidas137@gmail.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: Can current macro be accessed from interrupt context?
Date: Thu, 22 Oct 2009 14:06:17 +0200 [thread overview]
Message-ID: <20091022120613.GB4928@nowhere> (raw)
In-Reply-To: <f22d86810910220443u49cdfabg83ef836406cfb36d@mail.gmail.com>
On Thu, Oct 22, 2009 at 04:43:38AM -0700, Leonidas . wrote:
> > Yep.
> > For example we do that in the function graph tracer. Because we store return
> > addresses of functions in the "current" task structure. Even if the task
> > is interrupted, it still makes sense to use current because we want
> > to know the flow of execution as a linear thing per cpu, the interrupt
> > is part of that flow
> >
> > I hope that helps.
> >
>
> Can you give pointers to the source code of this project?
Yep, it's in kernel/trace/trace_functions_graph.c (with a little
part in arch/*/kernel/ftrace.c and arch/*/kernel/entry*.S)
and also parts in kernel/trace/ftrace.c
We do that from the former file in ftrace_push_return_trace()
and ftrace_pop_return_trace()
We deref current from whatever context, this part of the code doesn't care
about interrupt or process context, and this code can be called from
every contexts, since it is tracing 99% of the kernel function calls.
We do care about the context in which the trace has been taken while displaying
these traces to the user, later, just to inform the user, but this is already
post-processing at this stage, even though it's done from the kernel.
Anyway, the point is that it's safe to deref current from an irq handler.
But whether it makes sense to do that. It depends on what you want to do.
next prev parent reply other threads:[~2009-10-22 12:06 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-22 11:10 Can current macro be accessed from interrupt context? Leonidas .
2009-10-22 11:27 ` Frederic Weisbecker
2009-10-22 11:43 ` Leonidas .
2009-10-22 11:49 ` Leonidas .
2009-10-22 12:06 ` Frederic Weisbecker [this message]
2009-10-22 13:37 ` Leonidas .
2009-10-22 13:45 ` Arjan van de Ven
2009-10-22 15:17 ` Valdis.Kletnieks
2009-10-22 17:46 ` Leonidas .
2009-10-22 18:12 ` Leonidas .
2009-10-23 8:13 ` Clemens Ladisch
2009-10-23 9:34 ` Leonidas .
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091022120613.GB4928@nowhere \
--to=fweisbec@gmail.com \
--cc=leonidas137@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox