public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH]kernel/irq/chip.c:Modify the code note
@ 2009-11-04 12:11 Liuweni
  2009-11-04 13:06 ` Jiri Kosina
  2009-11-04 14:31 ` Liuweni
  0 siblings, 2 replies; 3+ messages in thread
From: Liuweni @ 2009-11-04 12:11 UTC (permalink / raw)
  To: linux-kernel; +Cc: qingshenlwy, xgr178

In the origin, the code notes are not fit for set_irq_msi. 
The function name is set_irq_data.

And, I change function note "handle_percpu_IRQ" to "handle_percpu_irq".


Signed-off-by: Liuwenyi <qingshenlwy@gmail.com>

------------------------------------------
diff --git a/kernel/irq/chip.c b/kernel/irq/chip.c
index c166019..ba566c2 100644
--- a/kernel/irq/chip.c
+++ b/kernel/irq/chip.c
@@ -166,11 +166,11 @@ int set_irq_data(unsigned int irq, void *data)
 EXPORT_SYMBOL(set_irq_data);
 
 /**
- *	set_irq_data - set irq type data for an irq
+ *	set_irq_msi - set MSI descriptor data for an irq
  *	@irq:	Interrupt number
  *	@entry:	Pointer to MSI descriptor data
  *
- *	Set the hardware irq controller data for an irq
+ *	Set the MSI descriptor entry for an irq
  */
 int set_irq_msi(unsigned int irq, struct msi_desc *entry)
 {
@@ -590,7 +590,7 @@ out_unlock:
 }
 
 /**
- *	handle_percpu_IRQ - Per CPU local irq handler
+ *	handle_percpu_irq - Per CPU local irq handler
  *	@irq:	the interrupt number
  *	@desc:	the interrupt description structure for this irq
  *

 				
--------------
Liuweni
2009-11-04


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH]kernel/irq/chip.c:Modify the code note
  2009-11-04 12:11 [PATCH]kernel/irq/chip.c:Modify the code note Liuweni
@ 2009-11-04 13:06 ` Jiri Kosina
  2009-11-04 14:31 ` Liuweni
  1 sibling, 0 replies; 3+ messages in thread
From: Jiri Kosina @ 2009-11-04 13:06 UTC (permalink / raw)
  To: Liuweni; +Cc: linux-kernel, qingshenlwy, xgr178

On Wed, 4 Nov 2009, Liuweni wrote:

> In the origin, the code notes are not fit for set_irq_msi. 
> The function name is set_irq_data.
> 
> And, I change function note "handle_percpu_IRQ" to "handle_percpu_irq".
> 
> 
> Signed-off-by: Liuwenyi <qingshenlwy@gmail.com>
> 
> ------------------------------------------
> diff --git a/kernel/irq/chip.c b/kernel/irq/chip.c
> index c166019..ba566c2 100644
> --- a/kernel/irq/chip.c
> +++ b/kernel/irq/chip.c
> @@ -166,11 +166,11 @@ int set_irq_data(unsigned int irq, void *data)
>  EXPORT_SYMBOL(set_irq_data);
>  
>  /**
> - *	set_irq_data - set irq type data for an irq
> + *	set_irq_msi - set MSI descriptor data for an irq
>   *	@irq:	Interrupt number
>   *	@entry:	Pointer to MSI descriptor data
>   *
> - *	Set the hardware irq controller data for an irq
> + *	Set the MSI descriptor entry for an irq
>   */

You have submitted this hunk separately before, and I already have it in 
my queue (and I have sent you a mail informing you about this being 
merged), so you'd better not include it as part of any further patch 
submissions.

-- 
Jiri Kosina
SUSE Labs, Novell Inc.


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: Re: [PATCH]kernel/irq/chip.c:Modify the code note
  2009-11-04 12:11 [PATCH]kernel/irq/chip.c:Modify the code note Liuweni
  2009-11-04 13:06 ` Jiri Kosina
@ 2009-11-04 14:31 ` Liuweni
  1 sibling, 0 replies; 3+ messages in thread
From: Liuweni @ 2009-11-04 14:31 UTC (permalink / raw)
  To: Jiri Kosina; +Cc: linux-kernel

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="gb2312", Size: 1850 bytes --]

Thank you very much.

Someone tell me that my pre-mail's format is incorrect. The correct format is
......
Changlog
......
Signed-off-by: yourname <your@mail>
----------------------
patch context

And I have not received your mail. Maybe The gmail play a trick.

Then, I re-submitt this hunk after a week.

But now, I have found your mail in the mail-list.



  


2009-11-04 



Liuweni 



·¢¼þÈË£º Jiri Kosina 
·¢ËÍʱ¼ä£º 2009-11-04  21:06:24 
ÊÕ¼þÈË£º Liuweni 
³­ËÍ£º linux-kernel; qingshenlwy; xgr178 
Ö÷Ì⣺ Re: [PATCH]kernel/irq/chip.c:Modify the code note 
 
On Wed, 4 Nov 2009, Liuweni wrote:
> In the origin, the code notes are not fit for set_irq_msi. 
> The function name is set_irq_data.
> 
> And, I change function note "handle_percpu_IRQ" to "handle_percpu_irq".
> 
> 
> Signed-off-by: Liuwenyi <qingshenlwy@gmail.com>
> 
> ------------------------------------------
> diff --git a/kernel/irq/chip.c b/kernel/irq/chip.c
> index c166019..ba566c2 100644
> --- a/kernel/irq/chip.c
> +++ b/kernel/irq/chip.c
> @@ -166,11 +166,11 @@ int set_irq_data(unsigned int irq, void *data)
>  EXPORT_SYMBOL(set_irq_data);
>  
>  /**
> - * set_irq_data - set irq type data for an irq
> + * set_irq_msi - set MSI descriptor data for an irq
>   * @irq: Interrupt number
>   * @entry: Pointer to MSI descriptor data
>   *
> - * Set the hardware irq controller data for an irq
> + * Set the MSI descriptor entry for an irq
>   */
You have submitted this hunk separately before, and I already have it in 
my queue (and I have sent you a mail informing you about this being 
merged), so you'd better not include it as part of any further patch 
submissions.
-- 
Jiri Kosina
SUSE Labs, Novell Inc.
ÿôèº{.nÇ+‰·Ÿ®‰­†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a­¢f£¢·hšïêÿ‘êçz_è®\x03(­éšŽŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨è­Ú&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2009-11-04 14:31 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-11-04 12:11 [PATCH]kernel/irq/chip.c:Modify the code note Liuweni
2009-11-04 13:06 ` Jiri Kosina
2009-11-04 14:31 ` Liuweni

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox