From: David Miller <davem@davemloft.net>
To: sfr@canb.auug.org.au
Cc: linux-next@vger.kernel.org, linux-kernel@vger.kernel.org,
kristoffer@gaisler.com
Subject: Re: linux-next: sparc tree build failure
Date: Thu, 05 Nov 2009 00:00:12 -0800 (PST) [thread overview]
Message-ID: <20091105.000012.61292273.davem@davemloft.net> (raw)
In-Reply-To: <20091104.235315.18303666.davem@davemloft.net>
From: David Miller <davem@davemloft.net>
Date: Wed, 04 Nov 2009 23:53:15 -0800 (PST)
> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Date: Thu, 5 Nov 2009 18:50:14 +1100
>
>> Caused by commit d4ac42a582e46d7f86f0acb4253a310423c72c4c ("sparc:
>> Support for GRLIB APBUART serial port"). I added the following patch for
>> today.
>
> Thanks, the real fix is to simply remove that include, it isn't
> actually needed and the CONFIG_OF dependency is sufficient.
Hmm, it took a tiny bit more than that :-) Here's what I commited
to fix this, thanks.
apbuart: Kill dependency on deprecated Sparc-only PROM interfaces.
Use the proper modern OF ones instead.
Noticed by Stephen Rothwell.
Signed-off-by: David S. Miller <davem@davemloft.net>
---
drivers/serial/apbuart.c | 12 ++++++------
1 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/serial/apbuart.c b/drivers/serial/apbuart.c
index c7883a3..5f9dec3 100644
--- a/drivers/serial/apbuart.c
+++ b/drivers/serial/apbuart.c
@@ -29,7 +29,6 @@
#include <linux/io.h>
#include <linux/serial_core.h>
#include <asm/irq.h>
-#include <asm/oplib.h>
#include "apbuart.h"
@@ -596,10 +595,9 @@ static struct of_platform_driver grlib_apbuart_of_driver = {
static void grlib_apbuart_configure(void)
{
static int enum_done;
- struct device_node *np;
+ struct device_node *np, *rp;
struct uart_port *port = NULL;
-
- int node;
+ const u32 *prop;
int freq_khz;
int v = 0, d = 0;
unsigned int addr;
@@ -610,8 +608,10 @@ static void grlib_apbuart_configure(void)
return;
/* Get bus frequency */
- node = prom_getchild(prom_root_node);
- freq_khz = prom_getint(node, "clock-frequency");
+ rp = of_find_node_by_name(NULL, "/");
+ rp = of_get_next_child(rp, NULL);
+ prop = of_get_property(rp, "clock-frequency", NULL);
+ freq_khz = *prop;
line = 0;
for_each_matching_node(np, apbuart_match) {
--
1.6.5.2
next prev parent reply other threads:[~2009-11-05 7:59 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-05 7:50 linux-next: sparc tree build failure Stephen Rothwell
2009-11-05 7:53 ` David Miller
2009-11-05 8:00 ` David Miller [this message]
2009-11-05 14:44 ` Kristoffer Glembo
2009-11-13 10:34 ` Kristoffer Glembo
2009-11-13 14:57 ` David Miller
-- strict thread matches above, loose matches on Subject: below --
2009-11-26 9:16 Stephen Rothwell
2009-11-26 23:28 ` David Miller
2009-11-27 9:00 ` Thomas Gleixner
2009-11-06 7:02 Stephen Rothwell
2009-11-06 8:19 ` David Miller
2009-11-06 8:26 ` David Miller
2009-11-06 8:27 ` David Miller
2009-11-07 2:35 ` Stephen Rothwell
2009-10-05 7:43 Stephen Rothwell
2009-10-05 7:45 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091105.000012.61292273.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=kristoffer@gaisler.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox