From: David Miller <davem@davemloft.net>
To: sfr@canb.auug.org.au
Cc: linux-next@vger.kernel.org, linux-kernel@vger.kernel.org,
kristoffer@gaisler.com
Subject: Re: linux-next: sparc tree build failure
Date: Fri, 06 Nov 2009 00:26:51 -0800 (PST) [thread overview]
Message-ID: <20091106.002651.21006753.davem@davemloft.net> (raw)
In-Reply-To: <20091106.001930.121210402.davem@davemloft.net>
From: David Miller <davem@davemloft.net>
Date: Fri, 06 Nov 2009 00:19:30 -0800 (PST)
> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Date: Fri, 6 Nov 2009 18:02:48 +1100
>
>> Caused by commit d4ac42a582e46d7f86f0acb4253a310423c72c4c ("sparc:
>> Support for GRLIB APBUART serial port") (yes again :-)). I have applied
>> my patch to make it only build on SPARC again ...
>>
>> (Including linux/of_platform.h - where struct of_platform_driver,
>> of_register_driver() and of_platform_bus_type are declared - would be a
>> good start ... and the code should probably be using
>> of_register_platform_driver() instead of of_register_driver() in any
>> case.)
>
> Sorry, sparc is getting those headers indirectly.
>
> I'll fix this up.
Stephen, can you let me know if this takes care of everything?
I also noticed that the of_driver was not being unregistered on
module unload.
apbuart: Fix build and missing driver unregister.
linux/of_platform.h needs to be included
OF driver needs to be unregistered
Signed-off-by: David S. Miller <davem@davemloft.net>
next prev parent reply other threads:[~2009-11-06 8:26 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-06 7:02 linux-next: sparc tree build failure Stephen Rothwell
2009-11-06 8:19 ` David Miller
2009-11-06 8:26 ` David Miller [this message]
2009-11-06 8:27 ` David Miller
2009-11-07 2:35 ` Stephen Rothwell
-- strict thread matches above, loose matches on Subject: below --
2009-11-26 9:16 Stephen Rothwell
2009-11-26 23:28 ` David Miller
2009-11-27 9:00 ` Thomas Gleixner
2009-11-05 7:50 Stephen Rothwell
2009-11-05 7:53 ` David Miller
2009-11-05 8:00 ` David Miller
2009-11-05 14:44 ` Kristoffer Glembo
2009-11-13 10:34 ` Kristoffer Glembo
2009-11-13 14:57 ` David Miller
2009-10-05 7:43 Stephen Rothwell
2009-10-05 7:45 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091106.002651.21006753.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=kristoffer@gaisler.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox