From: Pavel Machek <pavel@ucw.cz>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: Kuninori Morimoto <morimoto.kuninori@renesas.com>,
Magnus Damm <damm@opensource.se>,
alsa-devel@alsa-project.org, linux-pm@lists.linux-foundation.org,
linux-kernel@vger.kernel.org
Subject: Re: [linux-pm] Null suspend/resume functions
Date: Wed, 18 Nov 2009 17:09:08 +0100 [thread overview]
Message-ID: <20091118160908.GD20887@elf.ucw.cz> (raw)
In-Reply-To: <20091117124125.GD823@rakim.wolfsonmicro.main>
On Tue 2009-11-17 12:41:25, Mark Brown wrote:
> On Tue, Nov 17, 2009 at 12:52:36PM +0100, Pavel Machek wrote:
>
> > I believe that having few nop functions around the tree should not be
> > huge problem. If it is, you can introduce one shared top function into
> > the core...
>
> The problem I have with that is that for most APIs noop functions are a
> big fat warning sign that something is going wrong and the API is being
> abused. This then creates noise and code review problems in the driver
> code since you've got something that normally suggests a problem.
That still sounds like poor reason to add tests to core. But return 0
function for that purpose should be ok (and should make code easy to
review, too).
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2009-11-18 16:09 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <ud43sjtaf.wl%morimoto.kuninori@renesas.com>
2009-11-09 10:58 ` [alsa-devel] [PATCH 1/2 v2] ASoC: sh: fsi: Add runtime PM support Mark Brown
2009-11-09 13:31 ` Mark Brown
2009-11-16 15:30 ` Null suspend/resume functions Mark Brown
2009-11-16 19:07 ` Rafael J. Wysocki
2009-11-17 11:52 ` [linux-pm] " Pavel Machek
2009-11-17 12:41 ` Mark Brown
2009-11-18 16:09 ` Pavel Machek [this message]
2009-11-19 11:21 ` Mark Brown
2009-11-21 23:45 ` Pavel Machek
2009-11-23 11:02 ` Mark Brown
2009-11-24 11:57 ` Pavel Machek
2009-11-17 12:46 ` Magnus Damm
2009-11-17 12:59 ` Mark Brown
2009-11-17 22:14 ` Rafael J. Wysocki
2009-11-18 13:41 ` Mark Brown
2009-11-18 10:09 ` Magnus Damm
2009-11-18 12:05 ` Mark Brown
2009-11-27 11:06 ` [alsa-devel] [PATCH 1/2 v2] ASoC: sh: fsi: Add runtime PM support Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091118160908.GD20887@elf.ucw.cz \
--to=pavel@ucw.cz \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=damm@opensource.se \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=morimoto.kuninori@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox