* vfs related crash in 2.6.33-rc2 @ 2009-12-30 16:33 Marvin 2009-12-30 19:44 ` OGAWA Hirofumi 0 siblings, 1 reply; 8+ messages in thread From: Marvin @ 2009-12-30 16:33 UTC (permalink / raw) To: Linux Kernel Mailing List Hi, I'm getting a lot of these: kernel: general protection fault: 0000 [#1] SMP kernel: last sysfs file: /sys/devices/pci0000:00/0000:00:18.3/modalias kernel: CPU 0 kernel: Pid: 12177, comm: packagekitd Not tainted 2.6.33-rc2 #1 GA-MA69VM-S2/GA- MA69VM-S2 kernel: RIP: 0010:[<ffffffff81111984>] [<ffffffff81111984>] __d_lookup+0x84/0x140 kernel: RSP: 0018:ffff880032281bf8 EFLAGS: 00010286 kernel: RAX: bc004303ff008e00 RBX: bc004303ff008e00 RCX: 0000000000000011 kernel: RDX: 018721e0aefe22a8 RSI: ffff880032281ce8 RDI: ffff88003b4c8540 kernel: RBP: ffff880032281c48 R08: 0016c3c8f8b84e99 R09: 0000000000001000 kernel: R10: 61746f742f363331 R11: 0000000000000246 R12: bc004303ff008de8 kernel: R13: ffff88003b4c8540 R14: 00000000afeb6093 R15: ffff880032281ce8 kernel: FS: 00007fcee6297910(0000) GS:ffff880001a00000(0000) knlGS:00000000f76ba6c0 kernel: CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 kernel: CR2: 00007fcee6288b3c CR3: 000000000be7c000 CR4: 00000000000006f0 kernel: DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 kernel: DR3: 0000000000000000 DR6: 00000000ffff0ff0 DR7: 0000000000000400 kernel: Process packagekitd (pid: 12177, threadinfo ffff880032280000, task ffff88003a874320) kernel: Stack: kernel: ffff880032281c18 ffff88002150201c 0000000d264cf090 000000000000000d kernel: <0> ffff880032281c48 ffff880032281dd8 ffff880032281cf8 ffff880032281ce8 kernel: <0> ffff880038aa9a00 ffff880032281cf8 ffff880032281c98 ffffffff811069c5 kernel: Call Trace: kernel: [<ffffffff811069c5>] do_lookup+0x55/0x270 kernel: [<ffffffff8110905d>] link_path_walk+0x69d/0xe70 kernel: [<ffffffff811099b8>] path_walk+0x58/0xc0 kernel: [<ffffffff81109a73>] do_path_lookup+0x53/0xa0 kernel: [<ffffffff8110a6a3>] user_path_at+0x53/0xa0 kernel: [<ffffffff811edcab>] ? _atomic_dec_and_lock+0x6b/0x90 kernel: [<ffffffff811013f3>] ? cp_new_stat+0xf3/0x110 kernel: [<ffffffff81101617>] vfs_fstatat+0x37/0x70 kernel: [<ffffffff811016b9>] vfs_lstat+0x19/0x20 kernel: [<ffffffff811016df>] sys_newlstat+0x1f/0x50 kernel: [<ffffffff81002d2b>] system_call_fastpath+0x16/0x1b kernel: Code: e0 03 48 03 05 ee df 75 00 48 8b 18 8b 45 c4 48 85 db 48 89 45 c8 75 0f eb 71 0f 1f 44 00 00 48 8b 1b 48 85 db 74 64 4c 8d 63 e8 <48> 8b 03 45 39 74 24 30 0f 18 08 75 e7 4d 39 6c 24 28 75 e0 49 kernel: RIP [<ffffffff81111984>] __d_lookup+0x84/0x140 kernel: RSP <ffff880032281bf8> kernel: ---[ end trace 20357edf03a4cafd ]--- filesystem is ext4 (in case it matters). Cheers Marvin ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: vfs related crash in 2.6.33-rc2 2009-12-30 16:33 vfs related crash in 2.6.33-rc2 Marvin @ 2009-12-30 19:44 ` OGAWA Hirofumi 2009-12-30 20:44 ` Marvin 0 siblings, 1 reply; 8+ messages in thread From: OGAWA Hirofumi @ 2009-12-30 19:44 UTC (permalink / raw) To: Marvin; +Cc: Linux Kernel Mailing List Marvin <marvin24@gmx.de> writes: > Hi, > > I'm getting a lot of these: > > kernel: general protection fault: 0000 [#1] SMP > kernel: last sysfs file: /sys/devices/pci0000:00/0000:00:18.3/modalias > kernel: CPU 0 > kernel: Pid: 12177, comm: packagekitd Not tainted 2.6.33-rc2 #1 GA-MA69VM-S2/GA- > MA69VM-S2 > kernel: RIP: 0010:[<ffffffff81111984>] [<ffffffff81111984>] __d_lookup+0x84/0x140 > kernel: RSP: 0018:ffff880032281bf8 EFLAGS: 00010286 > kernel: RAX: bc004303ff008e00 RBX: bc004303ff008e00 RCX: 0000000000000011 > kernel: RDX: 018721e0aefe22a8 RSI: ffff880032281ce8 RDI: ffff88003b4c8540 > kernel: RBP: ffff880032281c48 R08: 0016c3c8f8b84e99 R09: 0000000000001000 > kernel: R10: 61746f742f363331 R11: 0000000000000246 R12: bc004303ff008de8 > kernel: R13: ffff88003b4c8540 R14: 00000000afeb6093 R15: ffff880032281ce8 > kernel: FS: 00007fcee6297910(0000) GS:ffff880001a00000(0000) knlGS:00000000f76ba6c0 > kernel: CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 > kernel: CR2: 00007fcee6288b3c CR3: 000000000be7c000 CR4: 00000000000006f0 > kernel: DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 > kernel: DR3: 0000000000000000 DR6: 00000000ffff0ff0 DR7: 0000000000000400 > kernel: Process packagekitd (pid: 12177, threadinfo ffff880032280000, task > ffff88003a874320) > kernel: Stack: > kernel: ffff880032281c18 ffff88002150201c 0000000d264cf090 000000000000000d > kernel: <0> ffff880032281c48 ffff880032281dd8 ffff880032281cf8 ffff880032281ce8 > kernel: <0> ffff880038aa9a00 ffff880032281cf8 ffff880032281c98 ffffffff811069c5 > kernel: Call Trace: > kernel: [<ffffffff811069c5>] do_lookup+0x55/0x270 > kernel: [<ffffffff8110905d>] link_path_walk+0x69d/0xe70 > kernel: [<ffffffff811099b8>] path_walk+0x58/0xc0 > kernel: [<ffffffff81109a73>] do_path_lookup+0x53/0xa0 > kernel: [<ffffffff8110a6a3>] user_path_at+0x53/0xa0 > kernel: [<ffffffff811edcab>] ? _atomic_dec_and_lock+0x6b/0x90 > kernel: [<ffffffff811013f3>] ? cp_new_stat+0xf3/0x110 > kernel: [<ffffffff81101617>] vfs_fstatat+0x37/0x70 > kernel: [<ffffffff811016b9>] vfs_lstat+0x19/0x20 > kernel: [<ffffffff811016df>] sys_newlstat+0x1f/0x50 > kernel: [<ffffffff81002d2b>] system_call_fastpath+0x16/0x1b > kernel: Code: e0 03 48 03 05 ee df 75 00 48 8b 18 8b 45 c4 48 85 db 48 89 45 c8 75 0f > eb 71 0f 1f 44 00 00 48 8b 1b 48 85 db 74 64 4c 8d 63 e8 <48> 8b 03 45 39 74 24 30 0f > 18 08 75 e7 4d 39 6c 24 28 75 e0 49 > kernel: RIP [<ffffffff81111984>] __d_lookup+0x84/0x140 > kernel: RSP <ffff880032281bf8> > kernel: ---[ end trace 20357edf03a4cafd ]--- > > filesystem is ext4 (in case it matters). BTW, are you using nfs client on this machine? -- OGAWA Hirofumi <hirofumi@mail.parknet.co.jp> ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: vfs related crash in 2.6.33-rc2 2009-12-30 19:44 ` OGAWA Hirofumi @ 2009-12-30 20:44 ` Marvin 2009-12-30 20:59 ` OGAWA Hirofumi 0 siblings, 1 reply; 8+ messages in thread From: Marvin @ 2009-12-30 20:44 UTC (permalink / raw) To: OGAWA Hirofumi; +Cc: Linux Kernel Mailing List > Marvin <marvin24@gmx.de> writes: > > Hi, > > > > I'm getting a lot of these: > > > > kernel: general protection fault: 0000 [#1] SMP > > kernel: last sysfs file: /sys/devices/pci0000:00/0000:00:18.3/modalias > > kernel: CPU 0 > > kernel: Pid: 12177, comm: packagekitd Not tainted 2.6.33-rc2 #1 > > ... > > > > filesystem is ext4 (in case it matters). > > BTW, are you using nfs client on this machine? > um - yes, now that I think about it... I killed a nfs umount process (because of an offline server) shortly before the oopses started to fire. Marvin ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: vfs related crash in 2.6.33-rc2 2009-12-30 20:44 ` Marvin @ 2009-12-30 20:59 ` OGAWA Hirofumi 2010-01-06 23:41 ` Andrew Morton 0 siblings, 1 reply; 8+ messages in thread From: OGAWA Hirofumi @ 2009-12-30 20:59 UTC (permalink / raw) To: Marvin; +Cc: Linux Kernel Mailing List Marvin <marvin24@gmx.de> writes: >> Marvin <marvin24@gmx.de> writes: >> > Hi, >> > >> > I'm getting a lot of these: >> > >> > kernel: general protection fault: 0000 [#1] SMP >> > kernel: last sysfs file: /sys/devices/pci0000:00/0000:00:18.3/modalias >> > kernel: CPU 0 >> > kernel: Pid: 12177, comm: packagekitd Not tainted 2.6.33-rc2 #1 >> > ... >> > >> > filesystem is ext4 (in case it matters). >> >> BTW, are you using nfs client on this machine? >> > > um - yes, now that I think about it... I killed a nfs umount process (because of an > offline server) shortly before the oopses started to fire. OK. Probably, this oops would be same with one which happened on my machine recently. That path in patch corrupts dcache hash, so it can be the cause of strange behavior or oops on dcache hash. If so, the attached patch would fix it. Thanks. -- OGAWA Hirofumi <hirofumi@mail.parknet.co.jp> Recent change is missing to update "rehash". With that change, it will become the cause of adding dentry to hash twice. This explains the reason of Oops (dereference the freed dentry in __d_lookup()) on my machine. Signed-off-by: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp> --- fs/nfs/dir.c | 1 + 1 file changed, 1 insertion(+) diff -puN fs/nfs/dir.c~nfs-d_rehash-fix fs/nfs/dir.c --- linux-2.6/fs/nfs/dir.c~nfs-d_rehash-fix 2009-12-28 06:18:09.000000000 +0900 +++ linux-2.6-hirofumi/fs/nfs/dir.c 2009-12-28 06:18:16.000000000 +0900 @@ -1615,6 +1615,7 @@ static int nfs_rename(struct inode *old_ goto out; new_dentry = dentry; + rehash = NULL; new_inode = NULL; } } _ ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: vfs related crash in 2.6.33-rc2 2009-12-30 20:59 ` OGAWA Hirofumi @ 2010-01-06 23:41 ` Andrew Morton 2010-01-06 23:55 ` Trond Myklebust 0 siblings, 1 reply; 8+ messages in thread From: Andrew Morton @ 2010-01-06 23:41 UTC (permalink / raw) To: OGAWA Hirofumi Cc: Marvin, Linux Kernel Mailing List, Trond Myklebust, linux-nfs On Thu, 31 Dec 2009 05:59:32 +0900 OGAWA Hirofumi <hirofumi@mail.parknet.co.jp> wrote: > Marvin <marvin24@gmx.de> writes: > > >> Marvin <marvin24@gmx.de> writes: > >> > Hi, > >> > > >> > I'm getting a lot of these: > >> > > >> > kernel: general protection fault: 0000 [#1] SMP > >> > kernel: last sysfs file: /sys/devices/pci0000:00/0000:00:18.3/modalias > >> > kernel: CPU 0 > >> > kernel: Pid: 12177, comm: packagekitd Not tainted 2.6.33-rc2 #1 > >> > ... > >> > > >> > filesystem is ext4 (in case it matters). > >> > >> BTW, are you using nfs client on this machine? > >> > > > > um - yes, now that I think about it... I killed a nfs umount process (because of an > > offline server) shortly before the oopses started to fire. > > OK. Probably, this oops would be same with one which happened on my > machine recently. That path in patch corrupts dcache hash, so it can be > the cause of strange behavior or oops on dcache hash. > > If so, the attached patch would fix it. > > Thanks. > -- > OGAWA Hirofumi <hirofumi@mail.parknet.co.jp> > > > Recent change is missing to update "rehash". With that change, it will > become the cause of adding dentry to hash twice. > > This explains the reason of Oops (dereference the freed dentry in > __d_lookup()) on my machine. > > Signed-off-by: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp> > --- > > fs/nfs/dir.c | 1 + > 1 file changed, 1 insertion(+) > > diff -puN fs/nfs/dir.c~nfs-d_rehash-fix fs/nfs/dir.c > --- linux-2.6/fs/nfs/dir.c~nfs-d_rehash-fix 2009-12-28 06:18:09.000000000 +0900 > +++ linux-2.6-hirofumi/fs/nfs/dir.c 2009-12-28 06:18:16.000000000 +0900 > @@ -1615,6 +1615,7 @@ static int nfs_rename(struct inode *old_ > goto out; > > new_dentry = dentry; > + rehash = NULL; > new_inode = NULL; > } > } Guys, what's the status of this fix? Did Marvin have a chance to test it? Are the NFS developers aware of it? Thanks. ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: vfs related crash in 2.6.33-rc2 2010-01-06 23:41 ` Andrew Morton @ 2010-01-06 23:55 ` Trond Myklebust 2010-01-07 9:27 ` Marvin 0 siblings, 1 reply; 8+ messages in thread From: Trond Myklebust @ 2010-01-06 23:55 UTC (permalink / raw) To: Andrew Morton Cc: OGAWA Hirofumi, Marvin, Linux Kernel Mailing List, linux-nfs On Wed, 2010-01-06 at 15:41 -0800, Andrew Morton wrote: > On Thu, 31 Dec 2009 05:59:32 +0900 > OGAWA Hirofumi <hirofumi@mail.parknet.co.jp> wrote: > > > Marvin <marvin24@gmx.de> writes: > > > > >> Marvin <marvin24@gmx.de> writes: > > >> > Hi, > > >> > > > >> > I'm getting a lot of these: > > >> > > > >> > kernel: general protection fault: 0000 [#1] SMP > > >> > kernel: last sysfs file: /sys/devices/pci0000:00/0000:00:18.3/modalias > > >> > kernel: CPU 0 > > >> > kernel: Pid: 12177, comm: packagekitd Not tainted 2.6.33-rc2 #1 > > >> > ... > > >> > > > >> > filesystem is ext4 (in case it matters). > > >> > > >> BTW, are you using nfs client on this machine? > > >> > > > > > > um - yes, now that I think about it... I killed a nfs umount process (because of an > > > offline server) shortly before the oopses started to fire. > > > > OK. Probably, this oops would be same with one which happened on my > > machine recently. That path in patch corrupts dcache hash, so it can be > > the cause of strange behavior or oops on dcache hash. > > > > If so, the attached patch would fix it. > > > > Thanks. > > -- > > OGAWA Hirofumi <hirofumi@mail.parknet.co.jp> > > > > > > Recent change is missing to update "rehash". With that change, it will > > become the cause of adding dentry to hash twice. > > > > This explains the reason of Oops (dereference the freed dentry in > > __d_lookup()) on my machine. > > > > Signed-off-by: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp> > > --- > > > > fs/nfs/dir.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff -puN fs/nfs/dir.c~nfs-d_rehash-fix fs/nfs/dir.c > > --- linux-2.6/fs/nfs/dir.c~nfs-d_rehash-fix 2009-12-28 06:18:09.000000000 +0900 > > +++ linux-2.6-hirofumi/fs/nfs/dir.c 2009-12-28 06:18:16.000000000 +0900 > > @@ -1615,6 +1615,7 @@ static int nfs_rename(struct inode *old_ > > goto out; > > > > new_dentry = dentry; > > + rehash = NULL; > > new_inode = NULL; > > } > > } > > Guys, what's the status of this fix? Did Marvin have a chance to test > it? Are the NFS developers aware of it? > > Thanks. > Sorry for the delay. The above fix looks correct to me, but I too would like a confirmation that it fixes the Oops before I push it to Linus. In the meantime, I've committed it to my linux-next branch. Cheers Trond ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: vfs related crash in 2.6.33-rc2 2010-01-06 23:55 ` Trond Myklebust @ 2010-01-07 9:27 ` Marvin 2010-01-07 13:45 ` Trond Myklebust 0 siblings, 1 reply; 8+ messages in thread From: Marvin @ 2010-01-07 9:27 UTC (permalink / raw) To: Trond Myklebust Cc: Andrew Morton, OGAWA Hirofumi, Linux Kernel Mailing List, linux-nfs Hi, > On Wed, 2010-01-06 at 15:41 -0800, Andrew Morton wrote: > > On Thu, 31 Dec 2009 05:59:32 +0900 > > > > OGAWA Hirofumi <hirofumi@mail.parknet.co.jp> wrote: > > > Marvin <marvin24@gmx.de> writes: > > > >> Marvin <marvin24@gmx.de> writes: > > > >> > Hi, > > > >> > > > > >> > I'm getting a lot of these: > > > >> > > > > >> > kernel: general protection fault: 0000 [#1] SMP > > > >> > kernel: last sysfs file: > > > >> > /sys/devices/pci0000:00/0000:00:18.3/modalias kernel: CPU 0 > > > >> > kernel: Pid: 12177, comm: packagekitd Not tainted 2.6.33-rc2 #1 > > > >> > ... > > > >> > > > > >> > filesystem is ext4 (in case it matters). > > > >> > > > >> BTW, are you using nfs client on this machine? > > > > > > > > um - yes, now that I think about it... I killed a nfs umount process > > > > (because of an offline server) shortly before the oopses started to > > > > fire. > > > > > > OK. Probably, this oops would be same with one which happened on my > > > machine recently. That path in patch corrupts dcache hash, so it can be > > > the cause of strange behavior or oops on dcache hash. > > > > > > If so, the attached patch would fix it. > > > > > > Thanks. > > > > Guys, what's the status of this fix? Did Marvin have a chance to test > > it? Are the NFS developers aware of it? > > > > Thanks. > > Sorry for the delay. The above fix looks correct to me, but I too would > like a confirmation that it fixes the Oops before I push it to Linus. > > In the meantime, I've committed it to my linux-next branch. It seems that I send the reply to Hirofumi only, sorry for that. The patch works fine - no oops anymore. Thanks Marvin ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: vfs related crash in 2.6.33-rc2 2010-01-07 9:27 ` Marvin @ 2010-01-07 13:45 ` Trond Myklebust 0 siblings, 0 replies; 8+ messages in thread From: Trond Myklebust @ 2010-01-07 13:45 UTC (permalink / raw) To: Marvin; +Cc: Andrew Morton, OGAWA Hirofumi, Linux Kernel Mailing List, linux-nfs On Thu, 2010-01-07 at 10:27 +0100, Marvin wrote: > It seems that I send the reply to Hirofumi only, sorry for that. The patch works fine > - no oops anymore. OK. Thanks for testing! Trond ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2010-01-07 13:45 UTC | newest] Thread overview: 8+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2009-12-30 16:33 vfs related crash in 2.6.33-rc2 Marvin 2009-12-30 19:44 ` OGAWA Hirofumi 2009-12-30 20:44 ` Marvin 2009-12-30 20:59 ` OGAWA Hirofumi 2010-01-06 23:41 ` Andrew Morton 2010-01-06 23:55 ` Trond Myklebust 2010-01-07 9:27 ` Marvin 2010-01-07 13:45 ` Trond Myklebust
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox