* [patch] hp-wmi: fix double free @ 2010-01-10 7:45 Dan Carpenter 2010-01-10 10:38 ` Alan Jenkins 0 siblings, 1 reply; 2+ messages in thread From: Dan Carpenter @ 2010-01-10 7:45 UTC (permalink / raw) To: linux-kernel kfree(obj) was called earlier. This was found by smatch and has only been compile tested. :/ Signed-off-by: Dan Carpenter <error27@gmail.com> --- orig/drivers/platform/x86/hp-wmi.c 2010-01-09 21:43:13.000000000 +0300 +++ devel/drivers/platform/x86/hp-wmi.c 2010-01-09 21:43:28.000000000 +0300 @@ -388,8 +388,6 @@ static void hp_wmi_notify(u32 value, voi } else printk(KERN_INFO "HP WMI: Unknown key pressed - %x\n", eventcode); - - kfree(obj); } static int __init hp_wmi_input_setup(void) ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [patch] hp-wmi: fix double free 2010-01-10 7:45 [patch] hp-wmi: fix double free Dan Carpenter @ 2010-01-10 10:38 ` Alan Jenkins 0 siblings, 0 replies; 2+ messages in thread From: Alan Jenkins @ 2010-01-10 10:38 UTC (permalink / raw) To: Dan Carpenter, linux-kernel; +Cc: ACPI Devel Maling List On 1/10/10, Dan Carpenter <error27@gmail.com> wrote: > kfree(obj) was called earlier. > > This was found by smatch and has only been compile tested. :/ I don't see hp-wmi in MAINTAINERS, but in general platform drivers go via the ACPI tree. It looks like several others have discovered this issue the hard way :-). <http://www.pubbs.net/kernel/201001/14288/>. Fortunately it has been fixed in the acpi tree and now submitted to Linus. <http://linux.derkeiler.com/Mailing-Lists/Kernel/2010-01/msg02511.html>. Regards Alan > --- orig/drivers/platform/x86/hp-wmi.c 2010-01-09 21:43:13.000000000 +0300 > +++ devel/drivers/platform/x86/hp-wmi.c 2010-01-09 21:43:28.000000000 +0300 > @@ -388,8 +388,6 @@ static void hp_wmi_notify(u32 value, voi > } else > printk(KERN_INFO "HP WMI: Unknown key pressed - %x\n", > eventcode); > - > - kfree(obj); > } ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-01-10 10:38 UTC | newest] Thread overview: 2+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2010-01-10 7:45 [patch] hp-wmi: fix double free Dan Carpenter 2010-01-10 10:38 ` Alan Jenkins
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox