[PATCH] Remove cflags from Makefile and fix Kconfig

[PATCH] Remove cflags from Makefile and fix Kconfig

[Mark Allyn]

This patch fixes bothe the Makefile and the Kconfig file

This is the fourth of seven patches for the rar_register driver
for Sunday, January 17, 2009

The rar stands for restricted access region. The restricted access
region is an area of memory that can be locked from access by the
x86 processor.

The purpose of the restricted access region is to safeguard confidential
information from any unauthorized software running on the x86 processor.

The purpose of this driver is to enable other drivers to obtain
the address ranges of the restricted regions as well as lock them.

This patch is referenced off the linux-next repository as pulled
on Sunday, January 17, 2010

Signed-off-by: Mark Allyn <mark.a.allyn@intel.com>

Date: January 17, 2010
---
 drivers/staging/rar/Kconfig  |    8 ++++++--
 drivers/staging/rar/Makefile |    1 -
 2 files changed, 6 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/rar/Kconfig b/drivers/staging/rar/Kconfig
index 17f8bf3..e923178 100644
--- a/drivers/staging/rar/Kconfig
+++ b/drivers/staging/rar/Kconfig
@@ -8,10 +8,14 @@ menu "RAR Register Driver"
 #
 config RAR_REGISTER
 	tristate "Restricted Access Region Register Driver"
-	default n
 	---help---
 		This driver allows other kernel drivers access to the
 		contents of the restricted access region control
-		registers.
+		registers. The restricted access regions are areas
+		of memory on the Intel ultra mobile platform which the
+		x86 processor (and software running thereupon) cannot
+		access for reading or writing. It is used the protect
+		sensitive information from unauthorized programms running
+		on the x86 processor.
 
 endmenu
diff --git a/drivers/staging/rar/Makefile b/drivers/staging/rar/Makefile
index d5954cc..7f1478b 100644
--- a/drivers/staging/rar/Makefile
+++ b/drivers/staging/rar/Makefile
@@ -1,2 +1 @@
-EXTRA_CFLAGS += -DLITTLE__ENDIAN
 obj-$(CONFIG_RAR_REGISTER) += rar_register.o
-- 
1.6.0.6

Re: [PATCH] Remove cflags from Makefile and fix Kconfig

[Randy Dunlap]

On Mon, 18 Jan 2010 13:22:54 -0800 Mark Allyn wrote:

> This patch fixes bothe the Makefile and the Kconfig file
> 
> This is the fourth of seven patches for the rar_register driver
> for Sunday, January 17, 2009
> 
> The rar stands for restricted access region. The restricted access
> region is an area of memory that can be locked from access by the
> x86 processor.
> 
> The purpose of the restricted access region is to safeguard confidential
> information from any unauthorized software running on the x86 processor.
> 
> The purpose of this driver is to enable other drivers to obtain
> the address ranges of the restricted regions as well as lock them.
> 
> This patch is referenced off the linux-next repository as pulled
> on Sunday, January 17, 2010
> 
> Signed-off-by: Mark Allyn <mark.a.allyn@intel.com>
> 
> Date: January 17, 2010
> ---
>  drivers/staging/rar/Kconfig  |    8 ++++++--
>  drivers/staging/rar/Makefile |    1 -
>  2 files changed, 6 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/rar/Kconfig b/drivers/staging/rar/Kconfig
> index 17f8bf3..e923178 100644
> --- a/drivers/staging/rar/Kconfig
> +++ b/drivers/staging/rar/Kconfig
> @@ -8,10 +8,14 @@ menu "RAR Register Driver"
>  #
>  config RAR_REGISTER
>  	tristate "Restricted Access Region Register Driver"
> -	default n
>  	---help---
>  		This driver allows other kernel drivers access to the
>  		contents of the restricted access region control
> -		registers.
> +		registers. The restricted access regions are areas
> +		of memory on the Intel ultra mobile platform which the
> +		x86 processor (and software running thereupon) cannot
> +		access for reading or writing. It is used the protect
		                                          ^^^
		                                          to

> +		sensitive information from unauthorized programms running
> +		on the x86 processor.
>  
>  endmenu
> diff --git a/drivers/staging/rar/Makefile b/drivers/staging/rar/Makefile
> index d5954cc..7f1478b 100644
> --- a/drivers/staging/rar/Makefile
> +++ b/drivers/staging/rar/Makefile
> @@ -1,2 +1 @@
> -EXTRA_CFLAGS += -DLITTLE__ENDIAN
>  obj-$(CONFIG_RAR_REGISTER) += rar_register.o
> -- 
> 1.6.0.6
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/


---
~Randy

Re: [PATCH] Remove cflags from Makefile and fix Kconfig

[Greg KH]

On Mon, Jan 18, 2010 at 01:22:54PM -0800, Mark Allyn wrote:
> This patch fixes bothe the Makefile and the Kconfig file

Fixes in what way?  The existing one does not look buggy to me.

thanks,

greg k-h