* [PATCH 5/5] Staging: comedi: fix bracing and kfree issue in ni_670x.c This is a patch to the ni_670x.c file that fixes up brace and kfree issue found by checkpatch.pl tool Signed-off-by: Graham M Howe<gman.1352@googlemail.com>
@ 2010-02-20 11:53 Graham M Howe
2010-02-25 23:50 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Graham M Howe @ 2010-02-20 11:53 UTC (permalink / raw)
To: gregkh, wfp5p; +Cc: devel, linux-kernel, Graham M Howe
---
drivers/staging/comedi/drivers/ni_670x.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/comedi/drivers/ni_670x.c b/drivers/staging/comedi/drivers/ni_670x.c
index fc5f90f..352b917 100644
--- a/drivers/staging/comedi/drivers/ni_670x.c
+++ b/drivers/staging/comedi/drivers/ni_670x.c
@@ -221,8 +221,6 @@ static int ni_670x_detach(struct comedi_device *dev)
{
printk("comedi%d: ni_670x: remove\n", dev->minor);
- if (dev->subdevices[0].range_table_list)
- kfree(dev->subdevices[0].range_table_list);
if (dev->private && devpriv->mite)
mite_unsetup(devpriv->mite);
--
1.6.3.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 5/5] Staging: comedi: fix bracing and kfree issue in ni_670x.c This is a patch to the ni_670x.c file that fixes up brace and kfree issue found by checkpatch.pl tool Signed-off-by: Graham M Howe<gman.1352@googlemail.com>
2010-02-20 11:53 [PATCH 5/5] Staging: comedi: fix bracing and kfree issue in ni_670x.c This is a patch to the ni_670x.c file that fixes up brace and kfree issue found by checkpatch.pl tool Signed-off-by: Graham M Howe<gman.1352@googlemail.com> Graham M Howe
@ 2010-02-25 23:50 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2010-02-25 23:50 UTC (permalink / raw)
To: Graham M Howe; +Cc: gregkh, wfp5p, devel, linux-kernel
The subject doesn't match what the patch did :(
On Sat, Feb 20, 2010 at 11:53:01AM +0000, Graham M Howe wrote:
> ---
> drivers/staging/comedi/drivers/ni_670x.c | 2 --
> 1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/comedi/drivers/ni_670x.c b/drivers/staging/comedi/drivers/ni_670x.c
> index fc5f90f..352b917 100644
> --- a/drivers/staging/comedi/drivers/ni_670x.c
> +++ b/drivers/staging/comedi/drivers/ni_670x.c
> @@ -221,8 +221,6 @@ static int ni_670x_detach(struct comedi_device *dev)
> {
> printk("comedi%d: ni_670x: remove\n", dev->minor);
>
> - if (dev->subdevices[0].range_table_list)
> - kfree(dev->subdevices[0].range_table_list);
You can't just not free the memory :(
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-02-26 0:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-02-20 11:53 [PATCH 5/5] Staging: comedi: fix bracing and kfree issue in ni_670x.c This is a patch to the ni_670x.c file that fixes up brace and kfree issue found by checkpatch.pl tool Signed-off-by: Graham M Howe<gman.1352@googlemail.com> Graham M Howe
2010-02-25 23:50 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox