From: Sascha Hauer <s.hauer@pengutronix.de>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Guennadi Liakhovetski <g.liakhovetski@gmx.de>,
Linux Media Mailing List <linux-media@vger.kernel.org>,
linux-arm-kernel@lists.infradead.org,
Mauro Carvalho Chehab <mchehab@infradead.org>,
Antonio Ospite <ospite@studenti.unina.it>,
Hans Verkuil <hverkuil@xs4all.nl>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] V4L/DVB: mx1-camera: compile fix
Date: Thu, 4 Mar 2010 20:42:41 +0100 [thread overview]
Message-ID: <20100304194241.GG19843@pengutronix.de> (raw)
In-Reply-To: <20100304192623.GA14587@pengutronix.de>
On Thu, Mar 04, 2010 at 08:26:23PM +0100, Uwe Kleine-König wrote:
> Hi Guennadi,
>
> On Thu, Mar 04, 2010 at 06:13:38PM +0100, Guennadi Liakhovetski wrote:
> > > +#undef DMA_BASE
> > > +#define DMA_BASE MX1_IO_ADDRESS(MX1_DMA_BASE_ADDR)
> >
> > I don't like this. Why the "undef"? Is DMA_BASE already defined? where and
> > what is it? If it is - we better use a different name, if not - just
> > remove the undef, please.
> yes, it's not pretty, but I wanted to make a minimal patch.
>
> arch/arm/plat-mxc/include/mach/dma-mx1-mx2.h has:
>
> #define DMA_BASE IO_ADDRESS(DMA_BASE_ADDR)
This is only used in the mx1 camera driver, so you can just remove it
from dma-mx1-mx2.h and use MX1_IO_ADDRESS(MX1_DMA_BASE_ADDR) in the camera
driver.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2010-03-04 19:43 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-04 16:54 [PATCH] V4L/DVB: mx1-camera: compile fix Uwe Kleine-König
2010-03-04 17:13 ` Guennadi Liakhovetski
2010-03-04 19:26 ` Uwe Kleine-König
2010-03-04 19:42 ` Sascha Hauer [this message]
2010-03-05 10:45 ` [PATCH v2] " Uwe Kleine-König
2010-03-12 9:22 ` Guennadi Liakhovetski
2010-03-12 9:41 ` Uwe Kleine-König
2010-03-12 9:58 ` Guennadi Liakhovetski
2010-03-16 9:52 ` [PATCH] " Uwe Kleine-König
2010-03-16 11:01 ` Guennadi Liakhovetski
2010-03-27 21:42 ` Uwe Kleine-König
2010-03-28 20:12 ` Guennadi Liakhovetski
2010-03-31 8:40 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100304194241.GG19843@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=g.liakhovetski@gmx.de \
--cc=hverkuil@xs4all.nl \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@infradead.org \
--cc=ospite@studenti.unina.it \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox