The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Dan Carpenter <error27@gmail.com>
To: Dave Airlie <airlied@redhat.com>
Cc: linux-kernel@vger.kernel.org
Subject: vga_switcheroo: locking question in vga_switcheroo_debugfs_write()
Date: Sat, 6 Mar 2010 14:04:14 +0300	[thread overview]
Message-ID: <20100306110414.GB4958@bicker> (raw)

Hi Dave,

drivers/gpu/vga/vga_switcheroo.c +362 vga_switcheroo_debugfs_write(101)
   277          mutex_lock(&vgasr_mutex);
   278
   279          if (!vgasr_priv.active)
   280                  return -EINVAL;

Is there a reason we return with the lock held here?  The other returns
from this function don't have the lock held.  I looked through the rest
of the file but didn't see any clues.

regards,
dan carpenter

                 reply	other threads:[~2010-03-06 11:04 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100306110414.GB4958@bicker \
    --to=error27@gmail.com \
    --cc=airlied@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox