The Linux Kernel Mailing List
 help / color / mirror / Atom feed
* vga_switcheroo: locking question in vga_switcheroo_debugfs_write()
@ 2010-03-06 11:04 Dan Carpenter
  0 siblings, 0 replies; only message in thread
From: Dan Carpenter @ 2010-03-06 11:04 UTC (permalink / raw)
  To: Dave Airlie; +Cc: linux-kernel

Hi Dave,

drivers/gpu/vga/vga_switcheroo.c +362 vga_switcheroo_debugfs_write(101)
   277          mutex_lock(&vgasr_mutex);
   278
   279          if (!vgasr_priv.active)
   280                  return -EINVAL;

Is there a reason we return with the lock held here?  The other returns
from this function don't have the lock held.  I looked through the rest
of the file but didn't see any clues.

regards,
dan carpenter

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2010-03-06 11:04 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-03-06 11:04 vga_switcheroo: locking question in vga_switcheroo_debugfs_write() Dan Carpenter

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox