From: Jean Delvare <khali@linux-fr.org>
To: Henrik Rydberg <rydberg@euromail.se>
Cc: lm-sensors@lm-sensors.org, linux-kernel@vger.kernel.org,
Alex Murray <murray.alex@gmail.com>
Subject: Re: [PATCH] hwmon: applesmc: Add temperature sensor labels to sysfs interface
Date: Tue, 4 May 2010 13:32:00 +0200 [thread overview]
Message-ID: <20100504133200.34413e2b@hyperion.delvare> (raw)
In-Reply-To: <4BE001E7.9030605@euromail.se>
On Tue, 04 May 2010 13:15:51 +0200, Henrik Rydberg wrote:
> Jean Delvare wrote:
> [...]
> >> @@ -1578,6 +1717,8 @@ static int __init applesmc_init(void)
> >> }
> >> ret = sysfs_create_file(&pdev->dev.kobj,
> >> temperature_attributes[i]);
> >
> > Missing error handling.
> >
> >> + ret = sysfs_create_file(&pdev->dev.kobj,
> >> + label_attributes[i]);
> >> if (ret)
> >> goto out_temperature;
> >> }
> >
>
> Shoot, my bad review. Will send a new patch. While at it, the same function
> seems to leak fan attribute groups. Want me to correct such issues (in another
> patch)?
Yes please. As a bugfix, that would even be a candidate for 2.6.34. I
have another patch (for asc7621) pending already.
--
Jean Delvare
prev parent reply other threads:[~2010-05-04 11:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-04 9:55 [PATCH] hwmon: applesmc: Add temperature sensor labels to sysfs interface Henrik Rydberg
2010-05-04 10:06 ` Jean Delvare
2010-05-04 11:15 ` Henrik Rydberg
2010-05-04 11:32 ` Jean Delvare [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100504133200.34413e2b@hyperion.delvare \
--to=khali@linux-fr.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lm-sensors@lm-sensors.org \
--cc=murray.alex@gmail.com \
--cc=rydberg@euromail.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox