* [PATCH] Add missing extern to heap_free declaration
@ 2010-05-26 18:28 Sebastien JAN
2010-05-26 18:35 ` Alexey Dobriyan
0 siblings, 1 reply; 3+ messages in thread
From: Sebastien JAN @ 2010-05-26 18:28 UTC (permalink / raw)
To: linux-kernel; +Cc: torvalds, Sebastien Jan
From: Sebastien Jan <s-jan@ti.com>
heap_free() function is defined in lib/prio_heap.c
Signed-off-by: Sebastien Jan <s-jan@ti.com>
---
include/linux/prio_heap.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/include/linux/prio_heap.h b/include/linux/prio_heap.h
index 0809435..fd67387 100644
--- a/include/linux/prio_heap.h
+++ b/include/linux/prio_heap.h
@@ -36,7 +36,7 @@ extern int heap_init(struct ptr_heap *heap, size_t size, gfp_t gfp_mask,
* heap_free - release a heap's storage
* @heap: the heap structure whose data should be released
*/
-void heap_free(struct ptr_heap *heap);
+extern void heap_free(struct ptr_heap *heap);
/**
* heap_insert - insert a value into the heap and return any overflowed value
--
1.6.3.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] Add missing extern to heap_free declaration
2010-05-26 18:28 [PATCH] Add missing extern to heap_free declaration Sebastien JAN
@ 2010-05-26 18:35 ` Alexey Dobriyan
2010-05-26 18:39 ` Sebastien Jan
0 siblings, 1 reply; 3+ messages in thread
From: Alexey Dobriyan @ 2010-05-26 18:35 UTC (permalink / raw)
To: Sebastien JAN; +Cc: linux-kernel, torvalds
On Wed, May 26, 2010 at 08:28:19PM +0200, Sebastien JAN wrote:
> heap_free() function is defined in lib/prio_heap.c
> --- a/include/linux/prio_heap.h
> +++ b/include/linux/prio_heap.h
> -void heap_free(struct ptr_heap *heap);
> +extern void heap_free(struct ptr_heap *heap);
This is totally unneeded.
In fact, externless prototypes are better.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Add missing extern to heap_free declaration
2010-05-26 18:35 ` Alexey Dobriyan
@ 2010-05-26 18:39 ` Sebastien Jan
0 siblings, 0 replies; 3+ messages in thread
From: Sebastien Jan @ 2010-05-26 18:39 UTC (permalink / raw)
To: Alexey Dobriyan
Cc: linux-kernel@vger.kernel.org, torvalds@linux-foundation.org
On Wednesday 26 May 2010 20:35:01 Alexey Dobriyan wrote:
> On Wed, May 26, 2010 at 08:28:19PM +0200, Sebastien JAN wrote:
> > heap_free() function is defined in lib/prio_heap.c
> >
> > --- a/include/linux/prio_heap.h
> > +++ b/include/linux/prio_heap.h
> > -void heap_free(struct ptr_heap *heap);
> > +extern void heap_free(struct ptr_heap *heap);
>
> This is totally unneeded.
>
> In fact, externless prototypes are better.
>
The attempt was to have a unified way of declaring the functions in this
file since the other functions have the 'export'.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-05-26 18:39 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-05-26 18:28 [PATCH] Add missing extern to heap_free declaration Sebastien JAN
2010-05-26 18:35 ` Alexey Dobriyan
2010-05-26 18:39 ` Sebastien Jan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox