From: Andrew Morton <akpm@linux-foundation.org>
To: Adam Lackorzynski <adam@os.inf.tu-dresden.de>
Cc: Jacob Pan <jacob.jun.pan@intel.com>,
"H. Peter Anvin" <hpa@zytor.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86, i8259: Only register sysdev for real PIC
Date: Thu, 3 Jun 2010 09:45:46 -0700 [thread overview]
Message-ID: <20100603094546.af7db742.akpm@linux-foundation.org> (raw)
In-Reply-To: <20100603090141.GA15516@os.inf.tu-dresden.de>
On Thu, 3 Jun 2010 11:01:41 +0200 Adam Lackorzynski <adam@os.inf.tu-dresden.de> wrote:
>
> On Wed Jun 02, 2010 at 18:18:14 -0700, Andrew Morton wrote:
> > On Wed, 2 Jun 2010 13:31:50 +0200 Adam Lackorzynski <adam@os.inf.tu-dresden.de> wrote:
> >
> > > Do not register the sysdev function when the null_legacy_pic is used so
> > > that the i8259 resume, suspend and shutdown functions are not called.
> >
> > What are the effects of this change? Does it fix an oops or a hang, or
> > nothing at all, or...?
>
> My platform makes use of the null_legacy_pic choice and oopses when
> doing a shutdown as the shutdown code goes through all the registered
> sysdevs and calls their shutdown method which in my case poke on a
> non-existing i8259. Imho the i8259 specific sysdev should only be
> registered if the i8259 is actually there.
OK, thanks. Important info, that. I'd say that makes it something we
should fix in 2.6.34.x and perhaps earlier.
prev parent reply other threads:[~2010-06-03 16:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-02 11:31 [PATCH] x86, i8259: Only register sysdev for real PIC Adam Lackorzynski
2010-06-03 1:18 ` Andrew Morton
2010-06-03 9:01 ` Adam Lackorzynski
2010-06-03 16:45 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100603094546.af7db742.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=adam@os.inf.tu-dresden.de \
--cc=hpa@zytor.com \
--cc=jacob.jun.pan@intel.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox