From: Anisse Astier <anisse@astier.eu>
To: Axel Lin <axel.lin@gmail.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
Matthew Garrett <mjg@redhat.com>,
Thomas Renninger <trenn@suse.de>,
Richard Purdie <rpurdie@linux.intel.com>,
Carlos Corbacho <carlos@strangeworlds.co.uk>,
platform-driver-x86@vger.kernel.org
Subject: Re: [PATCH] msi-wmi: make needlessly global symbols static
Date: Thu, 8 Jul 2010 10:34:42 +0200 [thread overview]
Message-ID: <20100708103442.28520f6f@destiny.ordissimo> (raw)
In-Reply-To: <1278553830.7162.9.camel@mola>
Hi Axel,
On Thu, 08 Jul 2010 09:50:30 +0800, Axel Lin <axel.lin@gmail.com> wrote :
> backlight is needlessly defined global.
> This patch makes the symbol static.
>
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
Acked-by: Anisse Astier <anisse@astier.eu>
Thanks,
Anisse
> ---
> drivers/platform/x86/msi-wmi.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/platform/x86/msi-wmi.c b/drivers/platform/x86/msi-wmi.c
> index d173600..42a5469 100644
> --- a/drivers/platform/x86/msi-wmi.c
> +++ b/drivers/platform/x86/msi-wmi.c
> @@ -57,7 +57,7 @@ static struct key_entry msi_wmi_keymap[] = {
> };
> static ktime_t last_pressed[ARRAY_SIZE(msi_wmi_keymap) - 1];
>
> -struct backlight_device *backlight;
> +static struct backlight_device *backlight;
>
> static int backlight_map[] = { 0x00, 0x33, 0x66, 0x99, 0xCC, 0xFF };
>
prev parent reply other threads:[~2010-07-08 8:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-08 1:50 [PATCH] msi-wmi: make needlessly global symbols static Axel Lin
2010-07-08 8:34 ` Anisse Astier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100708103442.28520f6f@destiny.ordissimo \
--to=anisse@astier.eu \
--cc=axel.lin@gmail.com \
--cc=carlos@strangeworlds.co.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=mjg@redhat.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rpurdie@linux.intel.com \
--cc=trenn@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox