* [PATCH] msi-wmi: make needlessly global symbols static
@ 2010-07-08 1:50 Axel Lin
2010-07-08 8:34 ` Anisse Astier
0 siblings, 1 reply; 2+ messages in thread
From: Axel Lin @ 2010-07-08 1:50 UTC (permalink / raw)
To: linux-kernel
Cc: Anisse Astier, Matthew Garrett, Thomas Renninger, Richard Purdie,
Carlos Corbacho, platform-driver-x86
backlight is needlessly defined global.
This patch makes the symbol static.
Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
drivers/platform/x86/msi-wmi.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/platform/x86/msi-wmi.c b/drivers/platform/x86/msi-wmi.c
index d173600..42a5469 100644
--- a/drivers/platform/x86/msi-wmi.c
+++ b/drivers/platform/x86/msi-wmi.c
@@ -57,7 +57,7 @@ static struct key_entry msi_wmi_keymap[] = {
};
static ktime_t last_pressed[ARRAY_SIZE(msi_wmi_keymap) - 1];
-struct backlight_device *backlight;
+static struct backlight_device *backlight;
static int backlight_map[] = { 0x00, 0x33, 0x66, 0x99, 0xCC, 0xFF };
--
1.5.4.3
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] msi-wmi: make needlessly global symbols static
2010-07-08 1:50 [PATCH] msi-wmi: make needlessly global symbols static Axel Lin
@ 2010-07-08 8:34 ` Anisse Astier
0 siblings, 0 replies; 2+ messages in thread
From: Anisse Astier @ 2010-07-08 8:34 UTC (permalink / raw)
To: Axel Lin
Cc: linux-kernel, Matthew Garrett, Thomas Renninger, Richard Purdie,
Carlos Corbacho, platform-driver-x86
Hi Axel,
On Thu, 08 Jul 2010 09:50:30 +0800, Axel Lin <axel.lin@gmail.com> wrote :
> backlight is needlessly defined global.
> This patch makes the symbol static.
>
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
Acked-by: Anisse Astier <anisse@astier.eu>
Thanks,
Anisse
> ---
> drivers/platform/x86/msi-wmi.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/platform/x86/msi-wmi.c b/drivers/platform/x86/msi-wmi.c
> index d173600..42a5469 100644
> --- a/drivers/platform/x86/msi-wmi.c
> +++ b/drivers/platform/x86/msi-wmi.c
> @@ -57,7 +57,7 @@ static struct key_entry msi_wmi_keymap[] = {
> };
> static ktime_t last_pressed[ARRAY_SIZE(msi_wmi_keymap) - 1];
>
> -struct backlight_device *backlight;
> +static struct backlight_device *backlight;
>
> static int backlight_map[] = { 0x00, 0x33, 0x66, 0x99, 0xCC, 0xFF };
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-07-08 8:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-07-08 1:50 [PATCH] msi-wmi: make needlessly global symbols static Axel Lin
2010-07-08 8:34 ` Anisse Astier
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox