The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: zr.public@gmail.com
Cc: isdn@linux-pingi.de, tj@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Drivers: isdn: Fixed warnings and odd code.
Date: Sat, 10 Jul 2010 14:33:29 -0700 (PDT)	[thread overview]
Message-ID: <20100710.143329.28809304.davem@davemloft.net> (raw)
In-Reply-To: <c40325e3d4cdc2f8c196b57c8581a0656828187c.1278796499.git.zr.public@gmail.com>

From: Zachary Richey <zr.public@gmail.com>
Date: Sat, 10 Jul 2010 17:27:29 -0400

> @@ -484,27 +484,18 @@ static int identify_board(unsigned long rambase, unsigned int iobase)
>  	 */
>  	outb(PRI_BASEPG_VAL, pgport);
>  	msleep_interruptible(1000);
> -	sig = readl(rambase + SIG_OFFSET);
> +	sig = readl(&rambase + SIG_OFFSET);

There is no way this is correct.

  reply	other threads:[~2010-07-10 21:33 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-10 21:27 [PATCH] Drivers: isdn: Fixed warnings and odd code Zachary Richey
2010-07-10 21:33 ` David Miller [this message]
2010-07-10 21:41 ` Sam Ravnborg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100710.143329.28809304.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=isdn@linux-pingi.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tj@kernel.org \
    --cc=zr.public@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox