The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Sam Ravnborg <sam@ravnborg.org>
To: Zachary Richey <zr.public@gmail.com>
Cc: isdn@linux-pingi.de, tj@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Drivers: isdn: Fixed warnings and odd code.
Date: Sat, 10 Jul 2010 23:41:56 +0200	[thread overview]
Message-ID: <20100710214156.GA15902@merkur.ravnborg.org> (raw)
In-Reply-To: <c40325e3d4cdc2f8c196b57c8581a0656828187c.1278796499.git.zr.public@gmail.com>

On Sat, Jul 10, 2010 at 05:27:29PM -0400, Zachary Richey wrote:
> This patch fixes compile time warnings in drivers/isdn/sc/init.c, and
> also cleans up what looked like redundant code in this file.


>  	outb(PRI_BASEPG_VAL, pgport);

Here we request Primary rate interface - see "PRI"

>  	msleep_interruptible(1000);
> -	sig = readl(rambase + SIG_OFFSET);
> +	sig = readl(&rambase + SIG_OFFSET);
>  	pr_debug("Looking for a signature, got 0x%lx\n", sig);
> -	if(sig == SIGNATURE)
> +	if (sig == SIGNATURE)
>  		return PRI_BOARD;
> -
> -	/*
> -	 * Try to identify a PRI card
> -	 */
> -	outb(BRI_BASEPG_VAL, pgport);

Here we request Basic rate interface - see "BRI".

So this is not redundant code and you cannot delete it.

	Sam

      parent reply	other threads:[~2010-07-10 21:41 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-10 21:27 [PATCH] Drivers: isdn: Fixed warnings and odd code Zachary Richey
2010-07-10 21:33 ` David Miller
2010-07-10 21:41 ` Sam Ravnborg [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100710214156.GA15902@merkur.ravnborg.org \
    --to=sam@ravnborg.org \
    --cc=isdn@linux-pingi.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tj@kernel.org \
    --cc=zr.public@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox