From: Jean Delvare <khali@linux-fr.org>
To: Guenter Roeck <guenter.roeck@ericsson.com>
Cc: Joe Perches <joe@perches.com>,
Andrew Morton <akpm@linux-foundation.org>,
Randy Dunlap <rdunlap@xenotime.net>,
Hans de Goede <hdegoede@redhat.com>,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
Samuel Ortiz <sameo@linux.intel.com>,
"David S. Miller" <davem@davemloft.net>,
Paul Goyette <paul@whooppee.com>,
"lm-sensors@lm-sensors.org" <lm-sensors@lm-sensors.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>
Subject: Re: [PATCH v2] hwmon: Add support for JEDEC JC 42.4 compliant temperature sensors
Date: Sun, 11 Jul 2010 18:21:38 +0200 [thread overview]
Message-ID: <20100711182138.132815e4@hyperion.delvare> (raw)
In-Reply-To: <20100711161658.GA23927@ericsson.com>
On Sun, 11 Jul 2010 09:16:58 -0700, Guenter Roeck wrote:
> On Sun, Jul 11, 2010 at 11:31:06AM -0400, Joe Perches wrote:
> > On Sun, 2010-07-11 at 07:53 -0700, Guenter Roeck wrote:
> > > + for (i = 0; i < ARRAY_SIZE(jc42_chips); i++) {
> > > + if (manid == jc42_chips[i].manid
> > > + && (devid & jc42_chips[i].devid_mask) ==
> > > + jc42_chips[i].devid) {
> > > + strlcpy(info->type, "jc42", I2C_NAME_SIZE);
> > > + return 0;
> > > + }
> > > + }
> >
> > Decidedly trivial:
> >
> > Kernel style seems to prefer having logical tests at
> > end of line rather than start of line.
>
> Ok. Would be nice to have checkpatch.pl complain about it, though,
> if it is a to-be-enforced rule.
Please, not again. This has been discussed before, with the conclusion
that nobody really cares and we don't want to add pointless warnings to
checkpatch.pl, which in the end will just dissuade people from running
the script and/or contributing to the kernel at all.
--
Jean Delvare
next prev parent reply other threads:[~2010-07-11 17:00 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-11 14:53 [PATCH v2] hwmon: Add support for JEDEC JC 42.4 compliant temperature sensors Guenter Roeck
2010-07-11 15:31 ` Joe Perches
2010-07-11 16:16 ` Guenter Roeck
2010-07-11 16:21 ` Jean Delvare [this message]
2010-07-11 18:57 ` [PATCH] scripts/checkpatch.pl: Add strict test of logical test continuations at beginning of line Joe Perches
2010-07-11 19:34 ` Jean Delvare
2010-07-11 19:52 ` Joe Perches
2010-07-11 21:15 ` Guenter Roeck
2010-07-12 22:49 ` [PATCH v2] hwmon: Add support for JEDEC JC 42.4 compliant temperature sensors Andrew Morton
2010-07-12 23:07 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100711182138.132815e4@hyperion.delvare \
--to=khali@linux-fr.org \
--cc=akpm@linux-foundation.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=davem@davemloft.net \
--cc=guenter.roeck@ericsson.com \
--cc=hdegoede@redhat.com \
--cc=joe@perches.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lm-sensors@lm-sensors.org \
--cc=paul@whooppee.com \
--cc=rdunlap@xenotime.net \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox