[PATCH] wm8960: fix compile error

[PATCH] wm8960: fix compile error

[Axel Lin]

This patch fixes compile error:
sound/soc/codecs/wm8960.c: In function 'wm8960_hw_params':
sound/soc/codecs/wm8960.c:511: error: 'codec' undeclared (first use in this function)
sound/soc/codecs/wm8960.c:511: error: (Each undeclared identifier is reported only once
sound/soc/codecs/wm8960.c:511: error: for each function it appears in.)
make[3]: *** [sound/soc/codecs/wm8960.o] Error 1
make[2]: *** [sound/soc/codecs] Error 2
make[1]: *** [sound/soc] Error 2
make: *** [sound] Error 2

Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
This patch is against Liam's multi-component branch.

Axel

 sound/soc/codecs/wm8960.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/sound/soc/codecs/wm8960.c b/sound/soc/codecs/wm8960.c
index e6df6e3..599c559 100644
--- a/sound/soc/codecs/wm8960.c
+++ b/sound/soc/codecs/wm8960.c
@@ -508,8 +508,8 @@ static int wm8960_hw_params(struct snd_pcm_substream *substream,
 			    struct snd_soc_dai *dai)
 {
 	struct snd_soc_pcm_runtime *rtd = substream->private_data;
-	struct wm8960_priv *wm8960 = snd_soc_codec_get_drvdata(codec);
 	struct snd_soc_codec *codec = rtd->codec;
+	struct wm8960_priv *wm8960 = snd_soc_codec_get_drvdata(codec);
 	u16 iface = snd_soc_read(codec, WM8960_IFACE1) & 0xfff3;
 	int i;
 
-- 
1.5.4.3

Re: [PATCH] wm8960: fix compile error

[Mark Brown]

On Tue, Jul 20, 2010 at 05:49:22PM +0800, Axel Lin wrote:

> This patch is against Liam's multi-component branch.

Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>

but please do try to bear in mind the feedback you've previously been
given about formatting your patches so they can be easily applied.  You
probably also want to look at the CC list for your patches, I'm not sure
why you're CCing Tejun here.

Re: [PATCH] wm8960: fix compile error

[Axel Lin]

hi Mark,

2010/7/20 Mark Brown <broonie@opensource.wolfsonmicro.com>:
> On Tue, Jul 20, 2010 at 05:49:22PM +0800, Axel Lin wrote:
>
>> This patch is against Liam's multi-component branch.
>
> Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
>
> but please do try to bear in mind the feedback you've previously been
> given about formatting your patches so they can be easily applied.  You
I'm a little bit confused about the meaning of "formatting your patches"?
Do you mean my patches cannot be applied by git am command? or?
( I tried the git am command with the mail I sent and it looks ok )

> probably also want to look at the CC list for your patches, I'm not sure
> why you're CCing Tejun here.

I get the CC list by get_maintainer.pl. Looks like the script gives me wrong
CC list.

Regards,
Axel

Re: [PATCH] wm8960: fix compile error

[Mark Brown]

On Tue, Jul 20, 2010 at 11:02:37PM +0800, Axel Lin wrote:
> 2010/7/20 Mark Brown <broonie@opensource.wolfsonmicro.com>:

> > but please do try to bear in mind the feedback you've previously been
> > given about formatting your patches so they can be easily applied.  You

> I'm a little bit confused about the meaning of "formatting your patches"?
> Do you mean my patches cannot be applied by git am command? or?
> ( I tried the git am command with the mail I sent and it looks ok )

In this case the main thing is the subject line which is not consistent
with other subject lines for patches in this area of code.  This sort of
stuff is particularly important when you're submitting large numbers of
very small fixes.

> > probably also want to look at the CC list for your patches, I'm not sure
> > why you're CCing Tejun here.

> I get the CC list by get_maintainer.pl. Looks like the script gives me wrong
> CC list.

Yes, you need to apply a bit of taste to the output - it's inclined to
generate false positives.  For matches from MAINTAINERS it's good but
for things generated from the git logs it can easily miss people or pick
up people who've been doing kernel wide cleanup work.