From: Oliver Neukum <oliver@neukum.org>
To: Michal Nazarewicz <m.nazarewicz@samsung.com>
Cc: linux-usb@vger.kernel.org,
Adam Kropelin <akropel1@rochester.rr.com>,
Xiaofan Chen <xiaofanc@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] USB: core: Choose configuration with lowest bConfigurationValue
Date: Thu, 22 Jul 2010 18:19:47 +0200 [thread overview]
Message-ID: <201007221819.47141.oliver@neukum.org> (raw)
In-Reply-To: <ed7910dcd6f62c058938f30aceb0fa5cd7c3f385.1279807231.git.m.nazarewicz@samsung.com>
Am Donnerstag, 22. Juli 2010, 16:09:10 schrieb Michal Nazarewicz:
> This patch removes code from usb_choose_configuration()
> responsible for ignoring the first USB device configuration if
> its first interface is RNDIS. Instead,
> usb_choose_configuration() chooses configuration with lowest
> bConfigurationValue. Linux' Ethernet gadget uses a lower
> bConfigurationValue for the second configuration which is
> a CDC configuration so this code should choose configuration
> that suits Linux better.
But what if the other side is not a Linux gadget? We need this code
to not select RNDIS on those devices. I am afraid we can't do this?
Regards
Oliver
prev parent reply other threads:[~2010-07-23 7:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <op.vf8lmjow7p4s8u@pikus>
2010-07-22 14:09 ` [PATCH] USB: core: Choose configuration with lowest bConfigurationValue Michal Nazarewicz
2010-07-22 14:22 ` Alan Stern
2010-07-22 14:28 ` Michał Nazarewicz
2010-07-22 16:19 ` Oliver Neukum [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201007221819.47141.oliver@neukum.org \
--to=oliver@neukum.org \
--cc=akropel1@rochester.rr.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=m.nazarewicz@samsung.com \
--cc=xiaofanc@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox