From: "Michał Nazarewicz" <m.nazarewicz@samsung.com>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: linux-usb@vger.kernel.org,
Adam Kropelin <akropel1@rochester.rr.com>,
Xiaofan Chen <xiaofanc@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] USB: core: Choose configuration with lowest bConfigurationValue
Date: Thu, 22 Jul 2010 16:28:03 +0200 [thread overview]
Message-ID: <op.vf80412e7p4s8u@pikus> (raw)
In-Reply-To: <Pine.LNX.4.44L0.1007221020440.1725-100000@iolanthe.rowland.org>
> On Thu, 22 Jul 2010, Michal Nazarewicz wrote:
>> This patch removes code from usb_choose_configuration()
>> responsible for ignoring the first USB device configuration if
>> its first interface is RNDIS. Instead,
>> usb_choose_configuration() chooses configuration with lowest
>> bConfigurationValue. Linux' Ethernet gadget uses a lower
>> bConfigurationValue for the second configuration which is
>> a CDC configuration so this code should choose configuration
>> that suits Linux better.
On Thu, 22 Jul 2010 16:22:37 +0200, Alan Stern <stern@rowland.harvard.edu> wrote:
> I don't like this idea. Choosing configs is a sensitive topic, since
> it is highly visible to users. It should be changed minimally, if at
> all.
Fine by me. I've just posted it to show what I had in mind.
--
Best regards, _ _
| Humble Liege of Serenely Enlightened Majesty of o' \,=./ `o
| Computer Science, Michał "mina86" Nazarewicz (o o)
+----[mina86*mina86.com]---[mina86*jabber.org]----ooO--(_)--Ooo--
next prev parent reply other threads:[~2010-07-22 14:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <op.vf8lmjow7p4s8u@pikus>
2010-07-22 14:09 ` [PATCH] USB: core: Choose configuration with lowest bConfigurationValue Michal Nazarewicz
2010-07-22 14:22 ` Alan Stern
2010-07-22 14:28 ` Michał Nazarewicz [this message]
2010-07-22 16:19 ` Oliver Neukum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=op.vf80412e7p4s8u@pikus \
--to=m.nazarewicz@samsung.com \
--cc=akropel1@rochester.rr.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
--cc=xiaofanc@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox