public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: mark gross <markgross@thegnar.org>
To: Saravana Kannan <skannan@codeaurora.org>
Cc: linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	"Rafael J. Wysocki" <rjw@sisk.pl>,
	James Bottomley <James.Bottomley@suse.de>,
	mark gross <markgross@thegnar.org>,
	Frederic Weisbecker <fweisbec@gmail.com>,
	Jonathan Corbet <corbet@lwn.net>
Subject: Re: [PATCH] pm_qos: Fix inline documentation.
Date: Thu, 26 Aug 2010 09:01:26 -0700	[thread overview]
Message-ID: <20100826160126.GA3414@gvim.org> (raw)
In-Reply-To: <1282801975-18348-1-git-send-email-skannan@codeaurora.org>

Acked-by: mark gross <markgross@thegnar.org>

thanks!

--mgross



On Wed, Aug 25, 2010 at 10:52:55PM -0700, Saravana Kannan wrote:
> Change-Id: I32f95b5a7e92236931b38fc4f1474f46ad22e298
> Signed-off-by: Saravana Kannan <skannan@codeaurora.org>
> ---
>  kernel/pm_qos_params.c |   10 ++++++----
>  1 files changed, 6 insertions(+), 4 deletions(-)
> 
> diff --git a/kernel/pm_qos_params.c b/kernel/pm_qos_params.c
> index 996a4de..132471f 100644
> --- a/kernel/pm_qos_params.c
> +++ b/kernel/pm_qos_params.c
> @@ -212,15 +212,17 @@ EXPORT_SYMBOL_GPL(pm_qos_request_active);
>  
>  /**
>   * pm_qos_add_request - inserts new qos request into the list
> - * @pm_qos_class: identifies which list of qos request to us
> + * @dep: pointer to a preallocated handle
> + * @pm_qos_class: identifies which list of qos request to use
>   * @value: defines the qos request
>   *
>   * This function inserts a new entry in the pm_qos_class list of requested qos
>   * performance characteristics.  It recomputes the aggregate QoS expectations
> - * for the pm_qos_class of parameters, and returns the pm_qos_request list
> - * element as a handle for use in updating and removal.  Call needs to save
> - * this handle for later use.
> + * for the pm_qos_class of parameters and initializes the pm_qos_request_list
> + * handle.  Caller needs to save this handle for later use in updates and
> + * removal.
>   */
> +
>  void pm_qos_add_request(struct pm_qos_request_list *dep,
>  			int pm_qos_class, s32 value)
>  {
> -- 
> 1.7.1.1
> ---
> Sent by an employee of the Qualcomm Innovation Center, Inc.
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.

  reply	other threads:[~2010-08-26 16:01 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-26  5:52 [PATCH] pm_qos: Fix inline documentation Saravana Kannan
2010-08-26 16:01 ` mark gross [this message]
2010-08-26 18:18   ` Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100826160126.GA3414@gvim.org \
    --to=markgross@thegnar.org \
    --cc=James.Bottomley@suse.de \
    --cc=corbet@lwn.net \
    --cc=fweisbec@gmail.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rjw@sisk.pl \
    --cc=skannan@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox