public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] pm_qos: Fix inline documentation.
@ 2010-08-26  5:52 Saravana Kannan
  2010-08-26 16:01 ` mark gross
  0 siblings, 1 reply; 3+ messages in thread
From: Saravana Kannan @ 2010-08-26  5:52 UTC (permalink / raw)
  To: linux-kernel
  Cc: linux-arm-msm, Rafael J. Wysocki, James Bottomley, mark gross,
	Frederic Weisbecker, Jonathan Corbet

Change-Id: I32f95b5a7e92236931b38fc4f1474f46ad22e298
Signed-off-by: Saravana Kannan <skannan@codeaurora.org>
---
 kernel/pm_qos_params.c |   10 ++++++----
 1 files changed, 6 insertions(+), 4 deletions(-)

diff --git a/kernel/pm_qos_params.c b/kernel/pm_qos_params.c
index 996a4de..132471f 100644
--- a/kernel/pm_qos_params.c
+++ b/kernel/pm_qos_params.c
@@ -212,15 +212,17 @@ EXPORT_SYMBOL_GPL(pm_qos_request_active);
 
 /**
  * pm_qos_add_request - inserts new qos request into the list
- * @pm_qos_class: identifies which list of qos request to us
+ * @dep: pointer to a preallocated handle
+ * @pm_qos_class: identifies which list of qos request to use
  * @value: defines the qos request
  *
  * This function inserts a new entry in the pm_qos_class list of requested qos
  * performance characteristics.  It recomputes the aggregate QoS expectations
- * for the pm_qos_class of parameters, and returns the pm_qos_request list
- * element as a handle for use in updating and removal.  Call needs to save
- * this handle for later use.
+ * for the pm_qos_class of parameters and initializes the pm_qos_request_list
+ * handle.  Caller needs to save this handle for later use in updates and
+ * removal.
  */
+
 void pm_qos_add_request(struct pm_qos_request_list *dep,
 			int pm_qos_class, s32 value)
 {
-- 
1.7.1.1
---
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] pm_qos: Fix inline documentation.
  2010-08-26  5:52 [PATCH] pm_qos: Fix inline documentation Saravana Kannan
@ 2010-08-26 16:01 ` mark gross
  2010-08-26 18:18   ` Rafael J. Wysocki
  0 siblings, 1 reply; 3+ messages in thread
From: mark gross @ 2010-08-26 16:01 UTC (permalink / raw)
  To: Saravana Kannan
  Cc: linux-kernel, linux-arm-msm, Rafael J. Wysocki, James Bottomley,
	mark gross, Frederic Weisbecker, Jonathan Corbet

Acked-by: mark gross <markgross@thegnar.org>

thanks!

--mgross



On Wed, Aug 25, 2010 at 10:52:55PM -0700, Saravana Kannan wrote:
> Change-Id: I32f95b5a7e92236931b38fc4f1474f46ad22e298
> Signed-off-by: Saravana Kannan <skannan@codeaurora.org>
> ---
>  kernel/pm_qos_params.c |   10 ++++++----
>  1 files changed, 6 insertions(+), 4 deletions(-)
> 
> diff --git a/kernel/pm_qos_params.c b/kernel/pm_qos_params.c
> index 996a4de..132471f 100644
> --- a/kernel/pm_qos_params.c
> +++ b/kernel/pm_qos_params.c
> @@ -212,15 +212,17 @@ EXPORT_SYMBOL_GPL(pm_qos_request_active);
>  
>  /**
>   * pm_qos_add_request - inserts new qos request into the list
> - * @pm_qos_class: identifies which list of qos request to us
> + * @dep: pointer to a preallocated handle
> + * @pm_qos_class: identifies which list of qos request to use
>   * @value: defines the qos request
>   *
>   * This function inserts a new entry in the pm_qos_class list of requested qos
>   * performance characteristics.  It recomputes the aggregate QoS expectations
> - * for the pm_qos_class of parameters, and returns the pm_qos_request list
> - * element as a handle for use in updating and removal.  Call needs to save
> - * this handle for later use.
> + * for the pm_qos_class of parameters and initializes the pm_qos_request_list
> + * handle.  Caller needs to save this handle for later use in updates and
> + * removal.
>   */
> +
>  void pm_qos_add_request(struct pm_qos_request_list *dep,
>  			int pm_qos_class, s32 value)
>  {
> -- 
> 1.7.1.1
> ---
> Sent by an employee of the Qualcomm Innovation Center, Inc.
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] pm_qos: Fix inline documentation.
  2010-08-26 16:01 ` mark gross
@ 2010-08-26 18:18   ` Rafael J. Wysocki
  0 siblings, 0 replies; 3+ messages in thread
From: Rafael J. Wysocki @ 2010-08-26 18:18 UTC (permalink / raw)
  To: markgross
  Cc: Saravana Kannan, linux-kernel, linux-arm-msm, James Bottomley,
	Frederic Weisbecker, Jonathan Corbet

On Thursday, August 26, 2010, mark gross wrote:
> Acked-by: mark gross <markgross@thegnar.org>

Applied to suspend-2.6/pm-fixes .

Thanks,
Rafael


> On Wed, Aug 25, 2010 at 10:52:55PM -0700, Saravana Kannan wrote:
> > Change-Id: I32f95b5a7e92236931b38fc4f1474f46ad22e298
> > Signed-off-by: Saravana Kannan <skannan@codeaurora.org>
> > ---
> >  kernel/pm_qos_params.c |   10 ++++++----
> >  1 files changed, 6 insertions(+), 4 deletions(-)
> > 
> > diff --git a/kernel/pm_qos_params.c b/kernel/pm_qos_params.c
> > index 996a4de..132471f 100644
> > --- a/kernel/pm_qos_params.c
> > +++ b/kernel/pm_qos_params.c
> > @@ -212,15 +212,17 @@ EXPORT_SYMBOL_GPL(pm_qos_request_active);
> >  
> >  /**
> >   * pm_qos_add_request - inserts new qos request into the list
> > - * @pm_qos_class: identifies which list of qos request to us
> > + * @dep: pointer to a preallocated handle
> > + * @pm_qos_class: identifies which list of qos request to use
> >   * @value: defines the qos request
> >   *
> >   * This function inserts a new entry in the pm_qos_class list of requested qos
> >   * performance characteristics.  It recomputes the aggregate QoS expectations
> > - * for the pm_qos_class of parameters, and returns the pm_qos_request list
> > - * element as a handle for use in updating and removal.  Call needs to save
> > - * this handle for later use.
> > + * for the pm_qos_class of parameters and initializes the pm_qos_request_list
> > + * handle.  Caller needs to save this handle for later use in updates and
> > + * removal.
> >   */
> > +
> >  void pm_qos_add_request(struct pm_qos_request_list *dep,
> >  			int pm_qos_class, s32 value)
> >  {
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
> 
> 


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2010-08-26 18:20 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-08-26  5:52 [PATCH] pm_qos: Fix inline documentation Saravana Kannan
2010-08-26 16:01 ` mark gross
2010-08-26 18:18   ` Rafael J. Wysocki

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox