From: David Miller <davem@davemloft.net>
To: agruen@suse.de
Cc: eparis@parisplace.org, netfilter@vger.kernel.org,
eparis@redhat.com, linux-kernel@vger.kernel.org,
schwab@redhat.com, tvrtko.ursulin@sophos.com
Subject: Re: aligned_{u64,be64,le64} defined in #ifdef __KERNEL__
Date: Sun, 29 Aug 2010 21:21:56 -0700 (PDT) [thread overview]
Message-ID: <20100829.212156.229740543.davem@davemloft.net> (raw)
In-Reply-To: <201008300326.30233.agruen@suse.de>
From: Andreas Gruenbacher <agruen@suse.de>
Date: Mon, 30 Aug 2010 03:26:29 +0200
> On Saturday 28 August 2010 01:51:53 Eric Paris wrote:
>> I liked this version until I realized that userspace doesn't have
>> aligned_u64 as a valid type.
>
> This looks like an error in include/linux/types.h. The aligned types should
> probably not be defined inside #ifdef __KERNEL__.
You can't do this, as it would pollute the POSIX namespace.
If we want a version of this type visible to userspace, it needs to,
for example, have double underscores prepended to the type name just
as we do for things like __u16 and __u32.
next prev parent reply other threads:[~2010-08-30 4:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-24 20:43 [PATCH -v2] fanotify: drops the packed attribute from userspace event metadata Eric Paris
2010-08-27 23:51 ` Eric Paris
2010-08-30 1:26 ` aligned_{u64,be64,le64} defined in #ifdef __KERNEL__ Andreas Gruenbacher
2010-08-30 4:21 ` David Miller [this message]
2010-08-30 10:58 ` Andreas Gruenbacher
2010-08-30 13:02 ` Jan Engelhardt
2010-08-31 1:42 ` David Miller
2010-10-06 6:05 ` Jan Engelhardt
2010-10-06 6:10 ` David Miller
2010-12-13 22:04 ` Iain Paton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100829.212156.229740543.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=agruen@suse.de \
--cc=eparis@parisplace.org \
--cc=eparis@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netfilter@vger.kernel.org \
--cc=schwab@redhat.com \
--cc=tvrtko.ursulin@sophos.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox