public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andreas Gruenbacher <agruen@suse.de>
To: Eric Paris <eparis@parisplace.org>, netfilter@vger.kernel.org
Cc: Eric Paris <eparis@redhat.com>,
	linux-kernel@vger.kernel.org, Andreas Schwab <schwab@redhat.com>,
	Tvrtko Ursulin <tvrtko.ursulin@sophos.com>
Subject: aligned_{u64,be64,le64} defined in #ifdef __KERNEL__
Date: Mon, 30 Aug 2010 03:26:29 +0200	[thread overview]
Message-ID: <201008300326.30233.agruen@suse.de> (raw)
In-Reply-To: <AANLkTimbQivEd7z1+sdLgChieGrY3c9iQWXVKgcYRAY=@mail.gmail.com>

On Saturday 28 August 2010 01:51:53 Eric Paris wrote:
> I liked this version until I realized that userspace doesn't have
> aligned_u64 as a valid type.

This looks like an error in include/linux/types.h.  The aligned types should 
probably not be defined inside #ifdef __KERNEL__.

The following other headers expose aligned 64-bit types to user space as well; 
copying the netfilter list:

	include/linux/if_ppp.h
	include/linux/netfilter/nfnetlink_queue.h
	include/linux/netfilter/nfnetlink_log.h
	include/linux/netfilter/xt_quota.h
	include/linux/netfilter/xt_connbytes.h

Otherwise, the definition of those types is really simple, and this would do 
in include/linux/fanotify.h until include/linux/types.h is fixed:

	#ifndef aligned_u64
	# define aligned_u64 __u64 __attribute__((aligned(8)))
	#endif

Thanks,
Andreas

  reply	other threads:[~2010-08-30  1:26 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-24 20:43 [PATCH -v2] fanotify: drops the packed attribute from userspace event metadata Eric Paris
2010-08-27 23:51 ` Eric Paris
2010-08-30  1:26   ` Andreas Gruenbacher [this message]
2010-08-30  4:21     ` aligned_{u64,be64,le64} defined in #ifdef __KERNEL__ David Miller
2010-08-30 10:58       ` Andreas Gruenbacher
2010-08-30 13:02         ` Jan Engelhardt
2010-08-31  1:42           ` David Miller
2010-10-06  6:05           ` Jan Engelhardt
2010-10-06  6:10             ` David Miller
2010-12-13 22:04               ` Iain Paton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201008300326.30233.agruen@suse.de \
    --to=agruen@suse.de \
    --cc=eparis@parisplace.org \
    --cc=eparis@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netfilter@vger.kernel.org \
    --cc=schwab@redhat.com \
    --cc=tvrtko.ursulin@sophos.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox