linux-next: build failure after merge of the final tree (suspend tree related)

linux-next: build failure after merge of the final tree (suspend tree related)

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1173 bytes --]

Hi Rafael,

After merging the final tree, today's linux-next build (powerpc allyesconfig)
failed like this:

kernel/power/swap.c: In function 'save_image_lzo':
kernel/power/swap.c:447: error: implicit declaration of function 'vmalloc'
kernel/power/swap.c:447: warning: assignment makes pointer from integer without a cast
kernel/power/swap.c:454: warning: assignment makes pointer from integer without a cast
kernel/power/swap.c:457: error: implicit declaration of function 'vfree'
kernel/power/swap.c:462: warning: assignment makes pointer from integer without a cast
kernel/power/swap.c: In function 'load_image_lzo':
kernel/power/swap.c:767: warning: assignment makes pointer from integer without a cast
kernel/power/swap.c:774: warning: assignment makes pointer from integer without a cast

Caused by commit 2b2609c19ff19361360552786bd252ef40dfe5ce ("PM /
Hibernate: Compress hibernation image with LZO").

See Rule 1 in Documentation/SubmitChecklist.  There is a missing include
of linux/vmalloc.h.

I have reverted that commit for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

Re: linux-next: build failure after merge of the final tree (suspend tree related)

[Bojan Smojver]

On Thu, 2010-09-09 at 12:58 +1000, Stephen Rothwell wrote:
> Caused by commit 2b2609c19ff19361360552786bd252ef40dfe5ce ("PM /
> Hibernate: Compress hibernation image with LZO").
> 
> See Rule 1 in Documentation/SubmitChecklist.  There is a missing
> include of linux/vmalloc.h. 

Thanks. I see I succeeded - first patch broke the build - yay! ;-)

Rafael,

Can you please add vmalloc.h to the thingy. I don't have commit access,
obviously.

-- 
Bojan

Re: linux-next: build failure after merge of the final tree (suspend tree related)

[Rafael J. Wysocki]

On Thursday, September 09, 2010, Bojan Smojver wrote:
> On Thu, 2010-09-09 at 12:58 +1000, Stephen Rothwell wrote:
> > Caused by commit 2b2609c19ff19361360552786bd252ef40dfe5ce ("PM /
> > Hibernate: Compress hibernation image with LZO").
> > 
> > See Rule 1 in Documentation/SubmitChecklist.  There is a missing
> > include of linux/vmalloc.h. 
> 
> Thanks. I see I succeeded - first patch broke the build - yay! ;-)
> 
> Rafael,
> 
> Can you please add vmalloc.h to the thingy. I don't have commit access,
> obviously.

Fixed and pushed back.

Thanks,
Rafael

linux-next: build failure after merge of the final tree (suspend tree related)

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 578 bytes --]

Hi all,

After merging the final tree, today's linux-next build (powerpc
allnoconfig) failed like this:

drivers/built-in.o: In function `_request_firmware':
firmware_class.c:(.text+0x385c8): undefined reference to `usermodehelper_is_disabled'

Caused by commit 3e61c4dd3e1e ("PM: Print a warning if firmware is
requested when tasks are frozen").  usermodehelper_is_disabled is only
defined if CONFIG_PM_SLEEP is set.

I have reverted that commit for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

Re: linux-next: build failure after merge of the final tree (suspend tree related)

[Rafael J. Wysocki]

On Friday, May 06, 2011, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the final tree, today's linux-next build (powerpc
> allnoconfig) failed like this:
> 
> drivers/built-in.o: In function `_request_firmware':
> firmware_class.c:(.text+0x385c8): undefined reference to `usermodehelper_is_disabled'
> 
> Caused by commit 3e61c4dd3e1e ("PM: Print a warning if firmware is
> requested when tasks are frozen").  usermodehelper_is_disabled is only
> defined if CONFIG_PM_SLEEP is set.
> 
> I have reverted that commit for today.

Should be fixed now, sorry for the trouble.

Thanks,
Rafael

linux-next: build failure after merge of the final tree (suspend tree related)

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 565 bytes --]

Hi Rafael,

After merging the final tree, today's linux-next build (powerpc
allyesconfig) failed like this:

kernel/swsusp.c:13:25: error: asm/suspend.h: No such file or directory
kernel/power/hibernate.c:28:25: error: asm/suspend.h: No such file or directory

Caused by commit 8f6404f39725 ("PM / Hibernate: Remove
arch_prepare_suspend()" which completely removed asm/suspend.h on
powerpc, frv and s390.

I have reverted that commit for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

Re: linux-next: build failure after merge of the final tree (suspend tree related)

[Rafael J. Wysocki]

On Tuesday, May 24, 2011, Stephen Rothwell wrote:
> Hi Rafael,
> 
> After merging the final tree, today's linux-next build (powerpc
> allyesconfig) failed like this:
> 
> kernel/swsusp.c:13:25: error: asm/suspend.h: No such file or directory
> kernel/power/hibernate.c:28:25: error: asm/suspend.h: No such file or directory
> 
> Caused by commit 8f6404f39725 ("PM / Hibernate: Remove
> arch_prepare_suspend()" which completely removed asm/suspend.h on
> powerpc, frv and s390.
> 
> I have reverted that commit for today.

Thanks for handling that, it should be fixed now.

Rafael