* [PATCH] kernel: trace: trace_kprobe.c: removed duplicated #include
@ 2010-10-15 19:27 Andrea Gelmini
2010-10-15 19:55 ` Mathieu Desnoyers
2010-10-16 13:11 ` Ingo Molnar
0 siblings, 2 replies; 3+ messages in thread
From: Andrea Gelmini @ 2010-10-15 19:27 UTC (permalink / raw)
To: linux-kernel
Cc: Andrea Gelmini, Steven Rostedt, Frederic Weisbecker, Ingo Molnar,
Masami Hiramatsu, Mathieu Desnoyers
Removed linux/uaccess.h
Signed-off-by: Andrea Gelmini <andrea.gelmini@gelma.net>
---
kernel/trace/trace_kprobe.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/kernel/trace/trace_kprobe.c b/kernel/trace/trace_kprobe.c
index 544301d..c5fb747 100644
--- a/kernel/trace/trace_kprobe.c
+++ b/kernel/trace/trace_kprobe.c
@@ -18,7 +18,6 @@
*/
#include <linux/module.h>
-#include <linux/uaccess.h>
#include <linux/kprobes.h>
#include <linux/seq_file.h>
#include <linux/slab.h>
@@ -479,7 +478,7 @@ struct probe_arg {
struct trace_probe {
struct list_head list;
struct kretprobe rp; /* Use rp.kp for kprobe use */
- unsigned long nhit;
+ unsigned long nhit;
unsigned int flags; /* For TP_FLAG_* */
const char *symbol; /* symbol name */
struct ftrace_event_class class;
--
1.7.3.1.181.g784b8
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] kernel: trace: trace_kprobe.c: removed duplicated #include
2010-10-15 19:27 [PATCH] kernel: trace: trace_kprobe.c: removed duplicated #include Andrea Gelmini
@ 2010-10-15 19:55 ` Mathieu Desnoyers
2010-10-16 13:11 ` Ingo Molnar
1 sibling, 0 replies; 3+ messages in thread
From: Mathieu Desnoyers @ 2010-10-15 19:55 UTC (permalink / raw)
To: Andrea Gelmini
Cc: linux-kernel, Steven Rostedt, Frederic Weisbecker, Ingo Molnar,
Masami Hiramatsu
* Andrea Gelmini (andrea.gelmini@gelma.net) wrote:
> Removed linux/uaccess.h
... and cleans up a whitespace.
Mathieu
>
> Signed-off-by: Andrea Gelmini <andrea.gelmini@gelma.net>
> ---
> kernel/trace/trace_kprobe.c | 3 +--
> 1 files changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/kernel/trace/trace_kprobe.c b/kernel/trace/trace_kprobe.c
> index 544301d..c5fb747 100644
> --- a/kernel/trace/trace_kprobe.c
> +++ b/kernel/trace/trace_kprobe.c
> @@ -18,7 +18,6 @@
> */
>
> #include <linux/module.h>
> -#include <linux/uaccess.h>
> #include <linux/kprobes.h>
> #include <linux/seq_file.h>
> #include <linux/slab.h>
> @@ -479,7 +478,7 @@ struct probe_arg {
> struct trace_probe {
> struct list_head list;
> struct kretprobe rp; /* Use rp.kp for kprobe use */
> - unsigned long nhit;
> + unsigned long nhit;
> unsigned int flags; /* For TP_FLAG_* */
> const char *symbol; /* symbol name */
> struct ftrace_event_class class;
> --
> 1.7.3.1.181.g784b8
>
--
Mathieu Desnoyers
Operating System Efficiency R&D Consultant
EfficiOS Inc.
http://www.efficios.com
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] kernel: trace: trace_kprobe.c: removed duplicated #include
2010-10-15 19:27 [PATCH] kernel: trace: trace_kprobe.c: removed duplicated #include Andrea Gelmini
2010-10-15 19:55 ` Mathieu Desnoyers
@ 2010-10-16 13:11 ` Ingo Molnar
1 sibling, 0 replies; 3+ messages in thread
From: Ingo Molnar @ 2010-10-16 13:11 UTC (permalink / raw)
To: Andrea Gelmini
Cc: linux-kernel, Steven Rostedt, Frederic Weisbecker, Ingo Molnar,
Masami Hiramatsu, Mathieu Desnoyers
* Andrea Gelmini <andrea.gelmini@gelma.net> wrote:
> Removed linux/uaccess.h
>
> Signed-off-by: Andrea Gelmini <andrea.gelmini@gelma.net>
> ---
> kernel/trace/trace_kprobe.c | 3 +--
> 1 files changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/kernel/trace/trace_kprobe.c b/kernel/trace/trace_kprobe.c
> index 544301d..c5fb747 100644
> --- a/kernel/trace/trace_kprobe.c
> +++ b/kernel/trace/trace_kprobe.c
> @@ -18,7 +18,6 @@
> */
>
> #include <linux/module.h>
> -#include <linux/uaccess.h>
> #include <linux/kprobes.h>
> #include <linux/seq_file.h>
> #include <linux/slab.h>
> @@ -479,7 +478,7 @@ struct probe_arg {
> struct trace_probe {
> struct list_head list;
> struct kretprobe rp; /* Use rp.kp for kprobe use */
> - unsigned long nhit;
> + unsigned long nhit;
> unsigned int flags; /* For TP_FLAG_* */
> const char *symbol; /* symbol name */
> struct ftrace_event_class class;
If you look at the actual code there's also other problems with the
vertical spacing of this and other structures (fetch_param, fetch_type,
trace_kprobe, etc.) defined here. Would be nice if you could check the
whole file and fix those too.
Thanks,
Ingo
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-10-16 13:12 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-10-15 19:27 [PATCH] kernel: trace: trace_kprobe.c: removed duplicated #include Andrea Gelmini
2010-10-15 19:55 ` Mathieu Desnoyers
2010-10-16 13:11 ` Ingo Molnar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox