Re: [PATCH] mtd: chips: Add SST38VF640x NOR-flashes

Re: [PATCH] mtd: chips: Add SST38VF640x NOR-flashes

[Wolfram Sang]

[-- Attachment #1: Type: text/plain, Size: 655 bytes --]

On Mon, Oct 18, 2010 at 10:06:50PM -0400, zhangyd wrote:
> Du to the wrong sector size description(The actual sector size is
> 8KBytes/sector, but the reporting size is 64KBytes/sector),you can get
> the wrong size of the memory. So they should be moved to the jedec_probe.
> 
> Signed-off-by: yidong zhang<zhangyd6@gmail.com>

NACK as long as Guillaume has not finished updating the SST-support for CFI. He
said he is working on this at the moment, let's give him a chance to finish :)

-- 
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 197 bytes --]

Re: [PATCH] mtd: chips: Add SST38VF640x NOR-flashes

[yidong zhang]

On Mon, Oct 18, 2010 at 10:56 PM, Wolfram Sang <w.sang@pengutronix.de> wrote:
> On Mon, Oct 18, 2010 at 10:06:50PM -0400, zhangyd wrote:
>> Du to the wrong sector size description(The actual sector size is
>> 8KBytes/sector, but the reporting size is 64KBytes/sector),you can get
>> the wrong size of the memory. So they should be moved to the jedec_probe.
>>
>> Signed-off-by: yidong zhang<zhangyd6@gmail.com>
>
> NACK as long as Guillaume has not finished updating the SST-support for CFI. He
> said he is working on this at the moment, let's give him a chance to finish :)

OK , Thanks!

> --
> Pengutronix e.K.                           | Wolfram Sang                |
> Industrial Linux Solutions                 | http://www.pengutronix.de/  |
>
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.9 (GNU/Linux)
>
> iEYEARECAAYFAky8YBQACgkQD27XaX1/VRtz6ACeMLJleCWrFki71rpj+0ELYala
> A8sAnA6Frg62shANhZn7xEW1196rHBxr
> =P1xd
> -----END PGP SIGNATURE-----
>
>

[PATCH] mtd: chips: Add SST38VF640x NOR-flashes

[zhangyd]

Du to the wrong sector size description(The actual sector size is
8KBytes/sector, but the reporting size is 64KBytes/sector),you can get
the wrong size of the memory. So they should be moved to the jedec_probe.

Signed-off-by: yidong zhang<zhangyd6@gmail.com>
---
 drivers/mtd/chips/jedec_probe.c |   11 +++++++++++
 1 files changed, 11 insertions(+), 0 deletions(-)

diff --git a/drivers/mtd/chips/jedec_probe.c b/drivers/mtd/chips/jedec_probe.c
index d72a5fb..0e8df3b 100644
--- a/drivers/mtd/chips/jedec_probe.c
+++ b/drivers/mtd/chips/jedec_probe.c
@@ -163,6 +163,7 @@
 #define SST49LF030A	0x001C
 #define SST49LF040A	0x0051
 #define SST49LF080A	0x005B
+#define SST38VF6401	0x536B
 #define SST36VF3203	0x7354
 
 /* Toshiba */
@@ -1568,6 +1569,16 @@ static const struct amd_flash_info jedec_table[] = {
 			ERASEINFO(0x10000,64),
 		}
 	}, {
+		.mfr_id		= CFI_MFR_SST,
+		.dev_id		= SST38VF6401,
+		.name		= "SST 38VF6401",
+		.devtypes	= CFI_DEVICETYPE_X16,
+		.cmd_set	= P_ID_AMD_STD,
+		.nr_regions	= 1,
+		.regions	= {
+			ERASEINFO(0x10000,128),
+		}
+	}, {
 		.mfr_id		= CFI_MFR_ST,
 		.dev_id		= M29F800AB,
 		.name		= "ST M29F800AB",
-- 
1.7.2.3