public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] mfd: ab3550: fix error check
@ 2010-10-24 18:57 Nicolas Kaiser
  0 siblings, 0 replies; only message in thread
From: Nicolas Kaiser @ 2010-10-24 18:57 UTC (permalink / raw)
  To: Samuel Ortiz; +Cc: linux-kernel

It looks to me like it was intended to check the return value
at this point.

Signed-off-by: Nicolas Kaiser <nikai@nikai.net>
---
 drivers/mfd/ab3550-core.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/mfd/ab3550-core.c b/drivers/mfd/ab3550-core.c
index 8a98739..b8868cc 100644
--- a/drivers/mfd/ab3550-core.c
+++ b/drivers/mfd/ab3550-core.c
@@ -997,7 +997,7 @@ static ssize_t ab3550_val_write(struct file *file,
 	if (err)
 		return -EINVAL;
 
-	get_register_interruptible(ab, (u8)ab->debug_bank,
+	err = get_register_interruptible(ab, (u8)ab->debug_bank,
 		(u8)ab->debug_address, &regvalue);
 	if (err)
 		return -EINVAL;
-- 
1.7.2.2

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2010-10-24 18:59 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-10-24 18:57 [PATCH] mfd: ab3550: fix error check Nicolas Kaiser

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox