From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>,
LKML <linux-kernel@vger.kernel.org>, Ingo Molnar <mingo@elte.hu>
Subject: Re: [PATCH] perf, ui: Eliminate stack-smashing protection compiler complain
Date: Mon, 8 Nov 2010 00:51:00 +0300 [thread overview]
Message-ID: <20101107215100.GH13175@lenovo> (raw)
In-Reply-To: <20101107214900.GE11134@nowhere>
On Sun, Nov 07, 2010 at 10:49:02PM +0100, Frederic Weisbecker wrote:
> On Sat, Nov 06, 2010 at 11:47:24AM +0300, Cyrill Gorcunov wrote:
> > The gcc complains on Yes, No being allocated from stack space. Make
> > them conts to feel compiler happy.
> >
> > | CC util/ui/util.o
> > | cc1: warnings being treated as errors
> > | util/ui/util.c: In function ‘ui__dialog_yesno’:
> > | util/ui/util.c:108: error: not protecting function: no buffer at least 8 bytes long
> > | make: *** [util/ui/util.o] Error 1
> >
> > Signed-off-by: Cyrill Gorcunov <gorcunov@openvz.org>
> > CC: Arnaldo Carvalho de Melo <acme@redhat.com>
> > CC: Frédéric Weisbecker <fweisbec@gmail.com>
> > CC: Ingo Molnar <mingo@elte.hu>
> > ---
>
> I hope we can finally queue this one fix, the warning is there
> for a while now, and this patch looks quite sensible :)
>
yup, thanks for review ;)
prev parent reply other threads:[~2010-11-07 21:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-06 8:47 [PATCH] perf, ui: Eliminate stack-smashing protection compiler complain Cyrill Gorcunov
2010-11-07 21:49 ` Frederic Weisbecker
2010-11-07 21:51 ` Cyrill Gorcunov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101107215100.GH13175@lenovo \
--to=gorcunov@gmail.com \
--cc=acme@redhat.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox