* [PATCH] MFD: ab8500-core interrupt ffs bit bug
@ 2010-12-02 14:06 Mattias Wallin
2010-12-09 12:13 ` Samuel Ortiz
0 siblings, 1 reply; 4+ messages in thread
From: Mattias Wallin @ 2010-12-02 14:06 UTC (permalink / raw)
To: Samuel Ortiz; +Cc: linux-kernel, Linus Walleij, Mattias Wallin
This patch fixes a bug in ab8500 interrupt handling
Signed-off-by: Mattias Wallin <mattias.wallin@stericsson.com>
---
drivers/mfd/ab8500-core.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/mfd/ab8500-core.c b/drivers/mfd/ab8500-core.c
index dbe1c93..d9640a6 100644
--- a/drivers/mfd/ab8500-core.c
+++ b/drivers/mfd/ab8500-core.c
@@ -303,7 +303,7 @@ static irqreturn_t ab8500_irq(int irq, void *dev)
continue;
do {
- int bit = __ffs(status);
+ int bit = __ffs(value);
int line = i * 8 + bit;
handle_nested_irq(ab8500->irq_base + line);
--
1.7.2.2
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] MFD: ab8500-core interrupt ffs bit bug
2010-12-02 14:06 [PATCH] MFD: ab8500-core interrupt ffs bit bug Mattias Wallin
@ 2010-12-09 12:13 ` Samuel Ortiz
2010-12-10 8:18 ` Mattias Wallin
0 siblings, 1 reply; 4+ messages in thread
From: Samuel Ortiz @ 2010-12-09 12:13 UTC (permalink / raw)
To: Mattias Wallin; +Cc: linux-kernel, Linus Walleij
Hi Mattias,
On Thu, Dec 02, 2010 at 03:06:49PM +0100, Mattias Wallin wrote:
> This patch fixes a bug in ab8500 interrupt handling
Patch applied. This also looks like a good candidate for 2.6.37.
Cheers,
Samuel.
--
Intel Open Source Technology Centre
http://oss.intel.com/
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] MFD: ab8500-core interrupt ffs bit bug
2010-12-09 12:13 ` Samuel Ortiz
@ 2010-12-10 8:18 ` Mattias Wallin
2010-12-10 9:42 ` Samuel Ortiz
0 siblings, 1 reply; 4+ messages in thread
From: Mattias Wallin @ 2010-12-10 8:18 UTC (permalink / raw)
To: Samuel Ortiz; +Cc: linux-kernel@vger.kernel.org, Linus WALLEIJ
On 12/09/2010 01:13 PM, Samuel Ortiz wrote:
> Hi Mattias,
>
> On Thu, Dec 02, 2010 at 03:06:49PM +0100, Mattias Wallin wrote:
>> This patch fixes a bug in ab8500 interrupt handling
> Patch applied. This also looks like a good candidate for 2.6.37.
I agree, AB8500 interrupts gets lost without this patch so the error is bad.
Do you want me to do anything for this to happen?
>
> Cheers,
> Samuel.
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] MFD: ab8500-core interrupt ffs bit bug
2010-12-10 8:18 ` Mattias Wallin
@ 2010-12-10 9:42 ` Samuel Ortiz
0 siblings, 0 replies; 4+ messages in thread
From: Samuel Ortiz @ 2010-12-10 9:42 UTC (permalink / raw)
To: Mattias Wallin; +Cc: linux-kernel@vger.kernel.org, Linus WALLEIJ
On Fri, Dec 10, 2010 at 09:18:55AM +0100, Mattias Wallin wrote:
>
>
> On 12/09/2010 01:13 PM, Samuel Ortiz wrote:
> > Hi Mattias,
> >
> > On Thu, Dec 02, 2010 at 03:06:49PM +0100, Mattias Wallin wrote:
> >> This patch fixes a bug in ab8500 interrupt handling
> > Patch applied. This also looks like a good candidate for 2.6.37.
> I agree, AB8500 interrupts gets lost without this patch so the error is bad.
> Do you want me to do anything for this to happen?
No, the patch is already in my for-linus branch.
Cheers,
Samuel.
> >
> > Cheers,
> > Samuel.
> >
--
Intel Open Source Technology Centre
http://oss.intel.com/
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2010-12-10 9:42 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-12-02 14:06 [PATCH] MFD: ab8500-core interrupt ffs bit bug Mattias Wallin
2010-12-09 12:13 ` Samuel Ortiz
2010-12-10 8:18 ` Mattias Wallin
2010-12-10 9:42 ` Samuel Ortiz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox