public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] mfd: Use dummy_irq_chip for tc3589x
@ 2010-12-20 12:01 Samuel Ortiz
  0 siblings, 0 replies; 4+ messages in thread
From: Samuel Ortiz @ 2010-12-20 12:01 UTC (permalink / raw)
  To: Linus Walleij; +Cc: linux-kernel, Paul Mundt, Rabin Vincent


This also converts tc3589x to the new irq API.

Cc: Rabin Vincent <rabin.vincent@stericsson.com>
Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
---

Linus, this should go through your ux500-core branch as this is where the
tc3589x rename happens.

---
 drivers/mfd/tc3589x.c |   13 +------------
 1 files changed, 1 insertions(+), 12 deletions(-)

diff --git a/drivers/mfd/tc3589x.c b/drivers/mfd/tc3589x.c
index 32291fe..112efd3 100644
--- a/drivers/mfd/tc3589x.c
+++ b/drivers/mfd/tc3589x.c
@@ -170,17 +170,6 @@ again:
 	return IRQ_HANDLED;
 }
 
-static void tc3589x_irq_dummy(unsigned int irq)
-{
-	/* No mask/unmask at this level */
-}
-
-static struct irq_chip tc3589x_irq_chip = {
-	.name	= "tc3589x",
-	.mask	= tc3589x_irq_dummy,
-	.unmask	= tc3589x_irq_dummy,
-};
-
 static int tc3589x_irq_init(struct tc3589x *tc3589x)
 {
 	int base = tc3589x->irq_base;
@@ -188,7 +177,7 @@ static int tc3589x_irq_init(struct tc3589x *tc3589x)
 
 	for (irq = base; irq < base + TC3589x_NR_INTERNAL_IRQS; irq++) {
 		set_irq_chip_data(irq, tc3589x);
-		set_irq_chip_and_handler(irq, &tc3589x_irq_chip,
+		set_irq_chip_and_handler(irq, &dummy_irq_chip,
 					 handle_edge_irq);
 		set_irq_nested_thread(irq, 1);
 #ifdef CONFIG_ARM
-- 
1.7.2.3

-- 
Intel Open Source Technology Centre
http://oss.intel.com/

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH] mfd: Use dummy_irq_chip for tc3589x
@ 2010-12-20 12:09 Samuel Ortiz
  2010-12-20 12:35 ` Linus WALLEIJ
  0 siblings, 1 reply; 4+ messages in thread
From: Samuel Ortiz @ 2010-12-20 12:09 UTC (permalink / raw)
  To: Linus Walleij; +Cc: linux-kernel, Paul Mundt, Rabin Vincent


This also converts tc3589x to the new irq API.

Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
---

Linus, this should go through your ux500-core branch as this is where the
tc3589x rename happens.

(Patch resent with Linus Walleij's correct email address)

---
 drivers/mfd/tc3589x.c |   13 +------------
 1 files changed, 1 insertions(+), 12 deletions(-)

diff --git a/drivers/mfd/tc3589x.c b/drivers/mfd/tc3589x.c
index 32291fe..112efd3 100644
--- a/drivers/mfd/tc3589x.c
+++ b/drivers/mfd/tc3589x.c
@@ -170,17 +170,6 @@ again:
 	return IRQ_HANDLED;
 }
 
-static void tc3589x_irq_dummy(unsigned int irq)
-{
-	/* No mask/unmask at this level */
-}
-
-static struct irq_chip tc3589x_irq_chip = {
-	.name	= "tc3589x",
-	.mask	= tc3589x_irq_dummy,
-	.unmask	= tc3589x_irq_dummy,
-};
-
 static int tc3589x_irq_init(struct tc3589x *tc3589x)
 {
 	int base = tc3589x->irq_base;
@@ -188,7 +177,7 @@ static int tc3589x_irq_init(struct tc3589x *tc3589x)
 
 	for (irq = base; irq < base + TC3589x_NR_INTERNAL_IRQS; irq++) {
 		set_irq_chip_data(irq, tc3589x);
-		set_irq_chip_and_handler(irq, &tc3589x_irq_chip,
+		set_irq_chip_and_handler(irq, &dummy_irq_chip,
 					 handle_edge_irq);
 		set_irq_nested_thread(irq, 1);
 #ifdef CONFIG_ARM
-- 
1.7.2.3

-- 
Intel Open Source Technology Centre
http://oss.intel.com/

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* RE: [PATCH] mfd: Use dummy_irq_chip for tc3589x
  2010-12-20 12:09 Samuel Ortiz
@ 2010-12-20 12:35 ` Linus WALLEIJ
  2010-12-20 13:11   ` Samuel Ortiz
  0 siblings, 1 reply; 4+ messages in thread
From: Linus WALLEIJ @ 2010-12-20 12:35 UTC (permalink / raw)
  To: Samuel Ortiz; +Cc: linux-kernel, Paul Mundt, Rabin VINCENT

[Samuel]

> This also converts tc3589x to the new irq API.
> 
> Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
> ---
> 
> Linus, this should go through your ux500-core branch as this is where
> the
> tc3589x rename happens.

OK applied and pushed to ux500-core, you can drop this
tc35x stuff off the MFD tree now..

Yours,
Linus Walleij

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] mfd: Use dummy_irq_chip for tc3589x
  2010-12-20 12:35 ` Linus WALLEIJ
@ 2010-12-20 13:11   ` Samuel Ortiz
  0 siblings, 0 replies; 4+ messages in thread
From: Samuel Ortiz @ 2010-12-20 13:11 UTC (permalink / raw)
  To: Linus WALLEIJ; +Cc: linux-kernel, Paul Mundt, Rabin VINCENT

On Mon, Dec 20, 2010 at 01:35:56PM +0100, Linus WALLEIJ wrote:
> [Samuel]
> 
> > This also converts tc3589x to the new irq API.
> > 
> > Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
> > ---
> > 
> > Linus, this should go through your ux500-core branch as this is where
> > the
> > tc3589x rename happens.
> 
> OK applied and pushed to ux500-core, you can drop this
> tc35x stuff off the MFD tree now..
Done, thanks a lot.

Cheers,
Samuel.

-- 
Intel Open Source Technology Centre
http://oss.intel.com/

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2010-12-20 13:11 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-12-20 12:01 [PATCH] mfd: Use dummy_irq_chip for tc3589x Samuel Ortiz
  -- strict thread matches above, loose matches on Subject: below --
2010-12-20 12:09 Samuel Ortiz
2010-12-20 12:35 ` Linus WALLEIJ
2010-12-20 13:11   ` Samuel Ortiz

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox