[PATCH] PCI: sysfs: Update ROM to include default owner write access

[PATCH] PCI: sysfs: Update ROM to include default owner write access

[Alex Williamson]

The PCI sysfs ROM interface requires an enabling write to access
the ROM image, but the default file mode is 0400.  The original
proposed patch adding sysfs ROM support was a true read-only
interface, with the enabling bit coming in as a feature request.
I suspect it was simply an oversight that the file mode didn't
get updated to match the API.

Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
---

 drivers/pci/pci-sysfs.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/pci/pci-sysfs.c b/drivers/pci/pci-sysfs.c
index 63d5042..8ecaac9 100644
--- a/drivers/pci/pci-sysfs.c
+++ b/drivers/pci/pci-sysfs.c
@@ -1149,7 +1149,7 @@ int __must_check pci_create_sysfs_dev_files (struct pci_dev *pdev)
 		sysfs_bin_attr_init(attr);
 		attr->size = rom_size;
 		attr->attr.name = "rom";
-		attr->attr.mode = S_IRUSR;
+		attr->attr.mode = S_IRUSR | S_IWUSR;
 		attr->read = pci_read_rom;
 		attr->write = pci_write_rom;
 		retval = sysfs_create_bin_file(&pdev->dev.kobj, attr);

Re: [PATCH] PCI: sysfs: Update ROM to include default owner write access

[Chris Wright]

* Alex Williamson (alex.williamson@redhat.com) wrote:
> The PCI sysfs ROM interface requires an enabling write to access
> the ROM image, but the default file mode is 0400.  The original
> proposed patch adding sysfs ROM support was a true read-only
> interface, with the enabling bit coming in as a feature request.
> I suspect it was simply an oversight that the file mode didn't
> get updated to match the API.

This is often not an issue given normal root capabilities, but once
we strip those capabilities, the default 0400 causes O_RDWR to fail.
As Alex said, given the only way to use the file is to write to it first,
making it writable makes sense.

> Signed-off-by: Alex Williamson <alex.williamson@redhat.com>

Acked-by: Chris Wright <chrisw@redhat.com>

Re: [PATCH] PCI: sysfs: Update ROM to include default owner write access

[Jesse Barnes]

On Wed, 05 Jan 2011 10:26:41 -0700
Alex Williamson <alex.williamson@redhat.com> wrote:

> The PCI sysfs ROM interface requires an enabling write to access
> the ROM image, but the default file mode is 0400.  The original
> proposed patch adding sysfs ROM support was a true read-only
> interface, with the enabling bit coming in as a feature request.
> I suspect it was simply an oversight that the file mode didn't
> get updated to match the API.
> 
> Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
> ---
> 
>  drivers/pci/pci-sysfs.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/pci/pci-sysfs.c b/drivers/pci/pci-sysfs.c
> index 63d5042..8ecaac9 100644
> --- a/drivers/pci/pci-sysfs.c
> +++ b/drivers/pci/pci-sysfs.c
> @@ -1149,7 +1149,7 @@ int __must_check pci_create_sysfs_dev_files (struct pci_dev *pdev)
>  		sysfs_bin_attr_init(attr);
>  		attr->size = rom_size;
>  		attr->attr.name = "rom";
> -		attr->attr.mode = S_IRUSR;
> +		attr->attr.mode = S_IRUSR | S_IWUSR;
>  		attr->read = pci_read_rom;
>  		attr->write = pci_write_rom;
>  		retval = sysfs_create_bin_file(&pdev->dev.kobj, attr);

Applied, thanks.

-- 
Jesse Barnes, Intel Open Source Technology Center